Re: [Qemu-devel] [PATCH] linux-user/sparc/signal.c: Remove unnecessary comment

2018-10-12 Thread Laurent Vivier
On 09/10/2018 20:40, Peter Maydell wrote: > Remove a comment suggesting that we need to call tb_flush() > after writing the SPARC signal frame trampoline insns. > This isn't necessary in QEMU, because (even if the guest > architecture requires explicit icache maintenance) we > ensure that memory

Re: [Qemu-devel] [PATCH] linux-user/sparc/signal.c: Remove unnecessary comment

2018-10-09 Thread Richard Henderson
On 10/9/18 12:45 PM, Laurent Vivier wrote: > Le 09/10/2018 à 20:40, Peter Maydell a écrit : >> Remove a comment suggesting that we need to call tb_flush() >> after writing the SPARC signal frame trampoline insns. >> This isn't necessary in QEMU, because (even if the guest >> architecture requires

Re: [Qemu-devel] [PATCH] linux-user/sparc/signal.c: Remove unnecessary comment

2018-10-09 Thread Laurent Vivier
Le 09/10/2018 à 20:40, Peter Maydell a écrit : > Remove a comment suggesting that we need to call tb_flush() > after writing the SPARC signal frame trampoline insns. > This isn't necessary in QEMU, because (even if the guest > architecture requires explicit icache maintenance) we > ensure that

[Qemu-devel] [PATCH] linux-user/sparc/signal.c: Remove unnecessary comment

2018-10-09 Thread Peter Maydell
Remove a comment suggesting that we need to call tb_flush() after writing the SPARC signal frame trampoline insns. This isn't necessary in QEMU, because (even if the guest architecture requires explicit icache maintenance) we ensure that memory writes result in invalidation of translated code from