Re: [Qemu-devel] [PATCH] linux-user: Add strace support for statx.

2019-06-19 Thread Laurent Vivier
Le 19/06/2019 à 01:53, Jim Wilson a écrit : > All of the flags need to be conditional as old systems don't have statx > support. Otherwise it works the same as other stat family syscalls. > This requires the pending patch to add statx support. > > Tested on Ubuntu 16.04 (no host statx) and

Re: [Qemu-devel] [PATCH] linux-user: Add strace support for statx.

2019-06-18 Thread Jim Wilson
On Tue, Jun 18, 2019 at 5:09 PM wrote: > === OUTPUT BEGIN === > ERROR: storage class should be at the beginning of the declaration > #25: FILE: linux-user/strace.c:979: > +UNUSED static struct flags statx_flags[] = { It is complaining about UNUSED, which is a macro that expands to attribute

Re: [Qemu-devel] [PATCH] linux-user: Add strace support for statx.

2019-06-18 Thread no-reply
Patchew URL: https://patchew.org/QEMU/20190618235313.13223-1-j...@sifive.com/ Hi, This series seems to have some coding style problems. See output below for more information: Subject: [Qemu-devel] [PATCH] linux-user: Add strace support for statx. Type: series Message-id: 20190618235313.13223

[Qemu-devel] [PATCH] linux-user: Add strace support for statx.

2019-06-18 Thread Jim Wilson
All of the flags need to be conditional as old systems don't have statx support. Otherwise it works the same as other stat family syscalls. This requires the pending patch to add statx support. Tested on Ubuntu 16.04 (no host statx) and Ubuntu 19.04 (with host statx) using a riscv32-linux