Re: [Qemu-devel] [PATCH] linux-user: Fix fault address truncation AArch64

2014-10-23 Thread Richard Henderson
On 10/23/2014 05:06 AM, Peter Maydell wrote: > On 23 October 2014 12:55, wrote: >> From: Riku Voipio >> >> On AArch64 the si_addr field of siginfo_t is truncated to 32 bits >> because the fault address passes through an uint32_t variable. This >> is fixed by changing the variable to uint64_t. >>

Re: [Qemu-devel] [PATCH] linux-user: Fix fault address truncation AArch64

2014-10-23 Thread Peter Maydell
On 23 October 2014 12:55, wrote: > From: Riku Voipio > > On AArch64 the si_addr field of siginfo_t is truncated to 32 bits > because the fault address passes through an uint32_t variable. This > is fixed by changing the variable to uint64_t. > > v2 by Riku - follow Peters suggestion and drop the

[Qemu-devel] [PATCH] linux-user: Fix fault address truncation AArch64

2014-10-23 Thread riku . voipio
From: Riku Voipio On AArch64 the si_addr field of siginfo_t is truncated to 32 bits because the fault address passes through an uint32_t variable. This is fixed by changing the variable to uint64_t. v2 by Riku - follow Peters suggestion and drop the addr variable since its only used once in the

Re: [Qemu-devel] [PATCH] linux-user: Fix fault address truncation AArch64

2014-10-10 Thread Peter Maydell
On 10 October 2014 15:58, Claudio Fontana wrote: > On 10.10.2014 13:32, Peter Maydell wrote: >> Thanks for catching this. Better to fix it by dropping >> the unnecessary local variable completely and just setting >> info._sifields._sigfault._addr = env->exception.vaddress; >> at the only point w

Re: [Qemu-devel] [PATCH] linux-user: Fix fault address truncation AArch64

2014-10-10 Thread Claudio Fontana
On 10.10.2014 13:32, Peter Maydell wrote: > On 10 October 2014 05:22, Amanieu d'Antras wrote: >> On AArch64 the si_addr field of siginfo_t is truncated to 32 bits >> because the fault address passes through an uint32_t variable. This >> is fixed by changing the variable to uint64_t. >> >> Signed-o

Re: [Qemu-devel] [PATCH] linux-user: Fix fault address truncation AArch64

2014-10-10 Thread Peter Maydell
On 10 October 2014 05:22, Amanieu d'Antras wrote: > On AArch64 the si_addr field of siginfo_t is truncated to 32 bits > because the fault address passes through an uint32_t variable. This > is fixed by changing the variable to uint64_t. > > Signed-off-by: Amanieu d'Antras > --- > linux-user/main

Re: [Qemu-devel] [PATCH] linux-user: Fix fault address truncation AArch64

2014-10-10 Thread Claudio Fontana
Reviewed-by: Claudio Fontana On 10.10.2014 06:22, Amanieu d'Antras wrote: > On AArch64 the si_addr field of siginfo_t is truncated to 32 bits > because the fault address passes through an uint32_t variable. This > is fixed by changing the variable to uint64_t. > > Signed-off-by: Amanieu d'Antras

[Qemu-devel] [PATCH] linux-user: Fix fault address truncation AArch64

2014-10-09 Thread Amanieu d'Antras
On AArch64 the si_addr field of siginfo_t is truncated to 32 bits because the fault address passes through an uint32_t variable. This is fixed by changing the variable to uint64_t. Signed-off-by: Amanieu d'Antras --- linux-user/main.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff -