Le 28/12/2017 à 20:34, Samuel Thibault a écrit :
> sched_get/setaffinity linux-user syscalls were missing conversions for
> little/big endian, which is hairy since longs may not be the same size
> either.
>
> For simplicity, this just introduces loops to convert bit by bit like is
> done for selec
Hi,
This series seems to have some coding style problems. See output below for
more information:
Type: series
Message-id: 20171228193439.18835-1-samuel.thiba...@ens-lyon.org
Subject: [Qemu-devel] [PATCH] linux-user: Fix sched_get/setaffinity conversion
=== TEST SCRIPT BEGIN ===
#!/bin/bash
sched_get/setaffinity linux-user syscalls were missing conversions for
little/big endian, which is hairy since longs may not be the same size
either.
For simplicity, this just introduces loops to convert bit by bit like is
done for select.
Signed-off-by: Samuel Thibault
---
linux-user/syscall.c
Laurent Vivier, on jeu. 28 déc. 2017 18:50:14 +0100, wrote:
> > +for (j = 0; j < abi_ubits; j++, bit++) {
> > +if (mask[bit / ubits] & (1UL << (bit % ubits))) {
>
> You should use __CPUMASK() and introduce a TARGET_CPUMASK().
Err, do we really want to u
Le 28/12/2017 à 15:11, Samuel Thibault a écrit :
> sched_get/setaffinity linux-user syscalls were missing conversions for
> little/big endian, which is hairy since longs may not be the same size
> either.
>
> For simplicity, this just introduces loops to convert bit by bit like is
> done for selec
sched_get/setaffinity linux-user syscalls were missing conversions for
little/big endian, which is hairy since longs may not be the same size
either.
For simplicity, this just introduces loops to convert bit by bit like is
done for select.
Signed-off-by: Samuel Thibault
---
linux-user/syscall.c
