Re: [Qemu-devel] [PATCH] loader: pad kernel size when loaded from a uImage

2010-08-03 Thread Richard Henderson
On 08/02/2010 01:35 PM, Hollis Blanchard wrote: >> Of those archs, only 2 actually use the return value of load_uimage >> to decide where to place blobs. PPC and MB. MB doesn't want any >> magic applied to the return value. That leaves us with _ONE_ single >> arch that needs magic that IMO is broke

Re: [Qemu-devel] [PATCH] loader: pad kernel size when loaded from a uImage

2010-08-02 Thread Hollis Blanchard
On Mon, Aug 2, 2010 at 12:56 PM, Edgar E. Iglesias wrote: > On Mon, Aug 02, 2010 at 12:33:54PM -0700, Hollis Blanchard wrote: >> >> You mean the one architecture, which by the way doesn't even use this >> API? That doesn't seem like a strong argument to me. Anyways, it's > > Are we looking at the

Re: [Qemu-devel] [PATCH] loader: pad kernel size when loaded from a uImage

2010-08-02 Thread Edgar E. Iglesias
On Mon, Aug 02, 2010 at 12:33:54PM -0700, Hollis Blanchard wrote: > On Mon, Aug 2, 2010 at 11:57 AM, Edgar E. Iglesias > wrote: > > On Mon, Aug 02, 2010 at 10:59:11AM -0700, Hollis Blanchard wrote: > >> On Sun, Aug 1, 2010 at 5:36 AM, Edgar E. Iglesias > >> wrote: > >> > On Sat, Jul 31, 2010 at 1

Re: [Qemu-devel] [PATCH] loader: pad kernel size when loaded from a uImage

2010-08-02 Thread Hollis Blanchard
On Mon, Aug 2, 2010 at 11:57 AM, Edgar E. Iglesias wrote: > On Mon, Aug 02, 2010 at 10:59:11AM -0700, Hollis Blanchard wrote: >> On Sun, Aug 1, 2010 at 5:36 AM, Edgar E. Iglesias >> wrote: >> > On Sat, Jul 31, 2010 at 12:56:42AM +0200, Edgar E. Iglesias wrote: >> >> On Thu, Jul 29, 2010 at 06:48:

Re: [Qemu-devel] [PATCH] loader: pad kernel size when loaded from a uImage

2010-08-02 Thread Edgar E. Iglesias
On Mon, Aug 02, 2010 at 10:59:11AM -0700, Hollis Blanchard wrote: > On Sun, Aug 1, 2010 at 5:36 AM, Edgar E. Iglesias > wrote: > > On Sat, Jul 31, 2010 at 12:56:42AM +0200, Edgar E. Iglesias wrote: > >> On Thu, Jul 29, 2010 at 06:48:24PM -0700, Hollis Blanchard wrote: > >> > The kernel's BSS size

Re: [Qemu-devel] [PATCH] loader: pad kernel size when loaded from a uImage

2010-08-02 Thread Hollis Blanchard
On Sun, Aug 1, 2010 at 5:36 AM, Edgar E. Iglesias wrote: > On Sat, Jul 31, 2010 at 12:56:42AM +0200, Edgar E. Iglesias wrote: >> On Thu, Jul 29, 2010 at 06:48:24PM -0700, Hollis Blanchard wrote: >> > The kernel's BSS size is lost by mkimage, which only considers file >> > size. As a result, loadin

Re: [Qemu-devel] [PATCH] loader: pad kernel size when loaded from a uImage

2010-08-01 Thread Edgar E. Iglesias
On Sat, Jul 31, 2010 at 12:56:42AM +0200, Edgar E. Iglesias wrote: > On Thu, Jul 29, 2010 at 06:48:24PM -0700, Hollis Blanchard wrote: > > The kernel's BSS size is lost by mkimage, which only considers file > > size. As a result, loading other blobs (e.g. device tree, initrd) > > immediately after

Re: [Qemu-devel] [PATCH] loader: pad kernel size when loaded from a uImage

2010-07-30 Thread Edgar E. Iglesias
On Thu, Jul 29, 2010 at 06:48:24PM -0700, Hollis Blanchard wrote: > The kernel's BSS size is lost by mkimage, which only considers file > size. As a result, loading other blobs (e.g. device tree, initrd) > immediately after the kernel location can result in them being zeroed by > the kernel's BSS i

Re: [Qemu-devel] [PATCH] loader: pad kernel size when loaded from a uImage

2010-07-29 Thread malc
On Thu, 29 Jul 2010, Hollis Blanchard wrote: > The kernel's BSS size is lost by mkimage, which only considers file > size. As a result, loading other blobs (e.g. device tree, initrd) > immediately after the kernel location can result in them being zeroed by > the kernel's BSS initialization code.

[Qemu-devel] [PATCH] loader: pad kernel size when loaded from a uImage

2010-07-29 Thread Hollis Blanchard
The kernel's BSS size is lost by mkimage, which only considers file size. As a result, loading other blobs (e.g. device tree, initrd) immediately after the kernel location can result in them being zeroed by the kernel's BSS initialization code. Signed-off-by: Hollis Blanchard --- hw/loader.c |