Re: [Qemu-devel] [PATCH] log: Redirect stderr to logfile if deamonized

On Tue, Mar 01, 2016 at 01:03:56PM +0100, Paolo Bonzini wrote: > > > On 01/03/2016 12:58, Daniel P. Berrange wrote: > > > > means that QEMU will never close stderr anymore, so libvirt things > > > > QEMU is still starting upforever. > > > > > > > > Given current libvirt behaviour /

Re: [Qemu-devel] [PATCH] log: Redirect stderr to logfile if deamonized

On 01/03/2016 12:58, Daniel P. Berrange wrote: > > > means that QEMU will never close stderr anymore, so libvirt things > > > QEMU is still starting upforever. > > > > > > Given current libvirt behaviour / expectations, I think the only > > > option is to revert this change. > > > > Why

Re: [Qemu-devel] [PATCH] log: Redirect stderr to logfile if deamonized

On Tue, Mar 01, 2016 at 12:51:03PM +0100, Paolo Bonzini wrote: > > > On 01/03/2016 12:47, Daniel P. Berrange wrote: > > means that QEMU will never close stderr anymore, so libvirt things > > QEMU is still starting upforever. > > > > Given current libvirt behaviour / expectations, I think

Re: [Qemu-devel] [PATCH] log: Redirect stderr to logfile if deamonized

On 01/03/2016 12:47, Daniel P. Berrange wrote: > means that QEMU will never close stderr anymore, so libvirt things > QEMU is still starting upforever. > > Given current libvirt behaviour / expectations, I think the only > option is to revert this change. Why not fix it instead? :) Paolo

Re: [Qemu-devel] [PATCH] log: Redirect stderr to logfile if deamonized

On 01/03/2016 12:15, Gerd Hoffmann wrote: > On Do, 2016-02-18 at 13:38 +0200, Dimitris Aragiorgis wrote: >> In case of daemonize, use the logfile passed with the -D option in >> order to redirect stderr to it instead of /dev/null. >> >> Also remove some unused code in log.h. > > Patch breaks

Re: [Qemu-devel] [PATCH] log: Redirect stderr to logfile if deamonized

On Tue, Mar 01, 2016 at 12:15:21PM +0100, Gerd Hoffmann wrote: > On Do, 2016-02-18 at 13:38 +0200, Dimitris Aragiorgis wrote: > > In case of daemonize, use the logfile passed with the -D option in > > order to redirect stderr to it instead of /dev/null. > > > > Also remove some unused code in

Re: [Qemu-devel] [PATCH] log: Redirect stderr to logfile if deamonized

On Do, 2016-02-18 at 13:38 +0200, Dimitris Aragiorgis wrote: > In case of daemonize, use the logfile passed with the -D option in > order to redirect stderr to it instead of /dev/null. > > Also remove some unused code in log.h. Patch breaks interaction with libvirt. libvirt hangs on startup,

Re: [Qemu-devel] [PATCH] log: Redirect stderr to logfile if deamonized

On 18/02/2016 18:12, Dimitris Aragiorgis wrote: > * Paolo Bonzini [2016-02-18 16:22:13 +0100]: > >> >> >> On 18/02/2016 12:38, Dimitris Aragiorgis wrote: >>> In case of daemonize, use the logfile passed with the -D option in >>> order to redirect stderr to it instead of

Re: [Qemu-devel] [PATCH] log: Redirect stderr to logfile if deamonized

* Paolo Bonzini [2016-02-18 16:22:13 +0100]: > > > On 18/02/2016 12:38, Dimitris Aragiorgis wrote: > > In case of daemonize, use the logfile passed with the -D option in > > order to redirect stderr to it instead of /dev/null. > > > > Also remove some unused code in

Re: [Qemu-devel] [PATCH] log: Redirect stderr to logfile if deamonized

On 18/02/2016 12:38, Dimitris Aragiorgis wrote: > In case of daemonize, use the logfile passed with the -D option in > order to redirect stderr to it instead of /dev/null. > > Also remove some unused code in log.h. > > Signed-off-by: Dimitris Aragiorgis > --- >

[Qemu-devel] [PATCH] log: Redirect stderr to logfile if deamonized

In case of daemonize, use the logfile passed with the -D option in order to redirect stderr to it instead of /dev/null. Also remove some unused code in log.h. Signed-off-by: Dimitris Aragiorgis --- include/qemu/log.h |6 -- os-posix.c |6 +-