Re: [Qemu-devel] [PATCH] machine: Add kvm-type property

2014-06-02 Thread Marcel Apfelbaum
On Sun, 2014-06-01 at 11:31 +0300, Marcel Apfelbaum wrote: On Fri, 2014-05-30 at 17:41 -0300, Eduardo Habkost wrote: The kvm-type machine option was left out when MachineState was introduced, preventing the kvm-type option from being used. Add the missing property. Very interesting how did

Re: [Qemu-devel] [PATCH] machine: Add kvm-type property

2014-06-02 Thread Eduardo Habkost
On Mon, Jun 02, 2014 at 11:56:59AM +0300, Marcel Apfelbaum wrote: On Sun, 2014-06-01 at 11:31 +0300, Marcel Apfelbaum wrote: On Fri, 2014-05-30 at 17:41 -0300, Eduardo Habkost wrote: The kvm-type machine option was left out when MachineState was introduced, preventing the kvm-type option

Re: [Qemu-devel] [PATCH] machine: Add kvm-type property

2014-06-01 Thread Marcel Apfelbaum
On Fri, 2014-05-30 at 17:41 -0300, Eduardo Habkost wrote: The kvm-type machine option was left out when MachineState was introduced, preventing the kvm-type option from being used. Add the missing property. Very interesting how did I miss that. Thanks! Marcel Signed-off-by: Eduardo Habkost

[Qemu-devel] [PATCH] machine: Add kvm-type property

2014-05-30 Thread Eduardo Habkost
The kvm-type machine option was left out when MachineState was introduced, preventing the kvm-type option from being used. Add the missing property. Signed-off-by: Eduardo Habkost ehabk...@redhat.com Cc: Andreas Färber afaer...@suse.de Cc: Aneesh Kumar K.V aneesh.ku...@linux.vnet.ibm.com Cc:

Re: [Qemu-devel] [PATCH] machine: Add kvm-type property

2014-05-30 Thread Paolo Bonzini
Il 30/05/2014 22:41, Eduardo Habkost ha scritto: diff --git a/include/hw/boards.h b/include/hw/boards.h index 2d2e2be..44956d6 100644 --- a/include/hw/boards.h +++ b/include/hw/boards.h @@ -111,6 +111,7 @@ struct MachineState { bool mem_merge; bool usb; char *firmware; +char

Re: [Qemu-devel] [PATCH] machine: Add kvm-type property

2014-05-30 Thread Eduardo Habkost
On Fri, May 30, 2014 at 10:46:56PM +0200, Paolo Bonzini wrote: Il 30/05/2014 22:41, Eduardo Habkost ha scritto: diff --git a/include/hw/boards.h b/include/hw/boards.h index 2d2e2be..44956d6 100644 --- a/include/hw/boards.h +++ b/include/hw/boards.h @@ -111,6 +111,7 @@ struct MachineState {

Re: [Qemu-devel] [PATCH] machine: Add kvm-type property

2014-05-30 Thread Alexander Graf
Am 30.05.2014 um 22:57 schrieb Eduardo Habkost ehabk...@redhat.com: On Fri, May 30, 2014 at 10:46:56PM +0200, Paolo Bonzini wrote: Il 30/05/2014 22:41, Eduardo Habkost ha scritto: diff --git a/include/hw/boards.h b/include/hw/boards.h index 2d2e2be..44956d6 100644 ---