Re: [Qemu-devel] [PATCH] mainloop.c: Keep unlocking BQL during busy-wait spin-out

2013-04-29 Thread Peter Lieven
On 21.04.2013 16:21, Peter Crosthwaite wrote: Hi Peter, On Fri, Apr 19, 2013 at 5:01 PM, Peter Lieven wrote: On 18.04.2013 16:35, Peter Crosthwaite wrote: Hi Peter, On Fri, Apr 19, 2013 at 12:22 AM, Peter Lieven wrote: On 15.04.2013 15:08, Anthony Liguori wrote: Peter Crosthwaite writes

Re: [Qemu-devel] [PATCH] mainloop.c: Keep unlocking BQL during busy-wait spin-out

2013-04-22 Thread Peter Lieven
On 21.04.2013 16:21, Peter Crosthwaite wrote: Hi Peter, On Fri, Apr 19, 2013 at 5:01 PM, Peter Lieven wrote: On 18.04.2013 16:35, Peter Crosthwaite wrote: Hi Peter, On Fri, Apr 19, 2013 at 12:22 AM, Peter Lieven wrote: On 15.04.2013 15:08, Anthony Liguori wrote: Peter Crosthwaite writes:

Re: [Qemu-devel] [PATCH] mainloop.c: Keep unlocking BQL during busy-wait spin-out

2013-04-21 Thread Peter Crosthwaite
Hi Peter, On Fri, Apr 19, 2013 at 5:01 PM, Peter Lieven wrote: > On 18.04.2013 16:35, Peter Crosthwaite wrote: >> >> Hi Peter, >> >> On Fri, Apr 19, 2013 at 12:22 AM, Peter Lieven >> wrote: >>> >>> On 15.04.2013 15:08, Anthony Liguori wrote: Peter Crosthwaite writes: > Modify

Re: [Qemu-devel] [PATCH] mainloop.c: Keep unlocking BQL during busy-wait spin-out

2013-04-19 Thread Peter Lieven
On 18.04.2013 16:35, Peter Crosthwaite wrote: Hi Peter, On Fri, Apr 19, 2013 at 12:22 AM, Peter Lieven wrote: On 15.04.2013 15:08, Anthony Liguori wrote: Peter Crosthwaite writes: Modify Anthony's starvation detection logic to keep the BQL unlocked until the starvation condition goes away.

Re: [Qemu-devel] [PATCH] mainloop.c: Keep unlocking BQL during busy-wait spin-out

2013-04-18 Thread Peter Crosthwaite
Hi Peter, On Fri, Apr 19, 2013 at 12:22 AM, Peter Lieven wrote: > On 15.04.2013 15:08, Anthony Liguori wrote: >> >> Peter Crosthwaite writes: >> >>> Modify Anthony's starvation detection logic to keep the BQL unlocked >>> until the starvation condition goes away. Otherwise the counter has to >>>

Re: [Qemu-devel] [PATCH] mainloop.c: Keep unlocking BQL during busy-wait spin-out

2013-04-18 Thread Peter Crosthwaite
On Mon, Apr 15, 2013 at 11:08 PM, Anthony Liguori wrote: > Peter Crosthwaite writes: > >> Modify Anthony's starvation detection logic to keep the BQL unlocked >> until the starvation condition goes away. Otherwise the counter has to >> count up to 1000 for each needed iteration until the busy-wai

Re: [Qemu-devel] [PATCH] mainloop.c: Keep unlocking BQL during busy-wait spin-out

2013-04-18 Thread Peter Lieven
On 15.04.2013 15:08, Anthony Liguori wrote: Peter Crosthwaite writes: Modify Anthony's starvation detection logic to keep the BQL unlocked until the starvation condition goes away. Otherwise the counter has to count up to 1000 for each needed iteration until the busy-wait is lifted. Reset the

Re: [Qemu-devel] [PATCH] mainloop.c: Keep unlocking BQL during busy-wait spin-out

2013-04-15 Thread Anthony Liguori
Paolo Bonzini writes: > Il 15/04/2013 15:08, Anthony Liguori ha scritto: >>> > Signed-off-by: Peter Crosthwaite >> I'm going through patches for 1.5 candidates. >> >> I believe the paste performance issue has been resolved now and this >> patch is no longer needed. I can't find a definitive st

Re: [Qemu-devel] [PATCH] mainloop.c: Keep unlocking BQL during busy-wait spin-out

2013-04-15 Thread Paolo Bonzini
Il 15/04/2013 15:08, Anthony Liguori ha scritto: >> > Signed-off-by: Peter Crosthwaite > I'm going through patches for 1.5 candidates. > > I believe the paste performance issue has been resolved now and this > patch is no longer needed. I can't find a definitive statement on the > list for that

Re: [Qemu-devel] [PATCH] mainloop.c: Keep unlocking BQL during busy-wait spin-out

2013-04-15 Thread Anthony Liguori
Peter Crosthwaite writes: > Modify Anthony's starvation detection logic to keep the BQL unlocked > until the starvation condition goes away. Otherwise the counter has to > count up to 1000 for each needed iteration until the busy-wait is > lifted. > > Reset the counter back to zero once glib_poll

[Qemu-devel] [PATCH] mainloop.c: Keep unlocking BQL during busy-wait spin-out

2013-04-06 Thread Peter Crosthwaite
Modify Anthony's starvation detection logic to keep the BQL unlocked until the starvation condition goes away. Otherwise the counter has to count up to 1000 for each needed iteration until the busy-wait is lifted. Reset the counter back to zero once glib_pollfds_fill returns with a non-zero timout