Re: [Qemu-devel] [PATCH] memory: Reintroduce dirty flag to optimize changes on disabled regions

2012-11-25 Thread Avi Kivity
On 11/25/2012 12:45 PM, Jan Kiszka wrote: > On 2012-11-25 11:18, Avi Kivity wrote: >> On 11/05/2012 02:37 PM, Jan Kiszka wrote: As I noted, init and destroy cannot cause a topology update. >>> >>> Ah, right. Why are we wrapping them in transaction_begin/commit at all then? >>> >> >> We a

Re: [Qemu-devel] [PATCH] memory: Reintroduce dirty flag to optimize changes on disabled regions

2012-11-25 Thread Jan Kiszka
On 2012-11-25 11:18, Avi Kivity wrote: > On 11/05/2012 02:37 PM, Jan Kiszka wrote: >>> >>> As I noted, init and destroy cannot cause a topology update. >> >> Ah, right. Why are we wrapping them in transaction_begin/commit at all then? >> > > We aren't. > > > void memory_region_destroy(MemoryRegi

Re: [Qemu-devel] [PATCH] memory: Reintroduce dirty flag to optimize changes on disabled regions

2012-11-25 Thread Avi Kivity
On 11/05/2012 02:37 PM, Jan Kiszka wrote: >> >> As I noted, init and destroy cannot cause a topology update. > > Ah, right. Why are we wrapping them in transaction_begin/commit at all then? > We aren't. void memory_region_destroy(MemoryRegion *mr) { assert(QTAILQ_EMPTY(&mr->subregions));

Re: [Qemu-devel] [PATCH] memory: Reintroduce dirty flag to optimize changes on disabled regions

2012-11-05 Thread Jan Kiszka
On 2012-11-05 13:33, Avi Kivity wrote: > On 11/05/2012 10:51 AM, Jan Kiszka wrote: >> On 2012-11-05 09:12, Avi Kivity wrote: >>> On 11/05/2012 08:26 AM, Jan Kiszka wrote: On 2012-11-04 20:21, Avi Kivity wrote: > On 11/04/2012 10:30 AM, Jan Kiszka wrote: >> From: Jan Kiszka >>

Re: [Qemu-devel] [PATCH] memory: Reintroduce dirty flag to optimize changes on disabled regions

2012-11-05 Thread Avi Kivity
On 11/05/2012 10:51 AM, Jan Kiszka wrote: > On 2012-11-05 09:12, Avi Kivity wrote: > > On 11/05/2012 08:26 AM, Jan Kiszka wrote: > >> On 2012-11-04 20:21, Avi Kivity wrote: > >>> On 11/04/2012 10:30 AM, Jan Kiszka wrote: > From: Jan Kiszka > > Cirrus is triggering this, e.g. during

Re: [Qemu-devel] [PATCH] memory: Reintroduce dirty flag to optimize changes on disabled regions

2012-11-05 Thread Jan Kiszka
On 2012-11-05 09:12, Avi Kivity wrote: > On 11/05/2012 08:26 AM, Jan Kiszka wrote: >> On 2012-11-04 20:21, Avi Kivity wrote: >>> On 11/04/2012 10:30 AM, Jan Kiszka wrote: From: Jan Kiszka Cirrus is triggering this, e.g. during Win2k boot: Changes only on disabled regions requir

Re: [Qemu-devel] [PATCH] memory: Reintroduce dirty flag to optimize changes on disabled regions

2012-11-05 Thread Avi Kivity
On 11/05/2012 08:26 AM, Jan Kiszka wrote: > On 2012-11-04 20:21, Avi Kivity wrote: > > On 11/04/2012 10:30 AM, Jan Kiszka wrote: > >> From: Jan Kiszka > >> > >> Cirrus is triggering this, e.g. during Win2k boot: Changes only on > >> disabled regions require no topology update when transaction dept

Re: [Qemu-devel] [PATCH] memory: Reintroduce dirty flag to optimize changes on disabled regions

2012-11-04 Thread Jan Kiszka
On 2012-11-04 20:21, Avi Kivity wrote: > On 11/04/2012 10:30 AM, Jan Kiszka wrote: >> From: Jan Kiszka >> >> Cirrus is triggering this, e.g. during Win2k boot: Changes only on >> disabled regions require no topology update when transaction depth drops >> to 0 again. > > 817dcc5368988b0 (pci: give

Re: [Qemu-devel] [PATCH] memory: Reintroduce dirty flag to optimize changes on disabled regions

2012-11-04 Thread Avi Kivity
On 11/04/2012 10:30 AM, Jan Kiszka wrote: > From: Jan Kiszka > > Cirrus is triggering this, e.g. during Win2k boot: Changes only on > disabled regions require no topology update when transaction depth drops > to 0 again. 817dcc5368988b0 (pci: give each device its own address space) mad this much

[Qemu-devel] [PATCH] memory: Reintroduce dirty flag to optimize changes on disabled regions

2012-11-04 Thread Jan Kiszka
From: Jan Kiszka Cirrus is triggering this, e.g. during Win2k boot: Changes only on disabled regions require no topology update when transaction depth drops to 0 again. Signed-off-by: Jan Kiszka --- memory.c | 17 +++-- 1 files changed, 15 insertions(+), 2 deletions(-) diff --gi