Re: [Qemu-devel] [PATCH] memory: fix usage of find_next_bit and find_next_zero_bit

2016-02-11 Thread Paolo Bonzini
On 10/02/2016 23:40, Peter Maydell wrote: > On 10 February 2016 at 14:11, Paolo Bonzini wrote: >> The last two arguments to these functions are the last and first bit to >> check relative to the base. The code was using incorrectly the first >> bit and the number of bits.

Re: [Qemu-devel] [PATCH] memory: fix usage of find_next_bit and find_next_zero_bit

2016-02-11 Thread Peter Maydell
On 10 February 2016 at 22:40, Peter Maydell wrote: > On 10 February 2016 at 14:11, Paolo Bonzini wrote: >> The last two arguments to these functions are the last and first bit to >> check relative to the base. The code was using incorrectly the

[Qemu-devel] [PATCH] memory: fix usage of find_next_bit and find_next_zero_bit

2016-02-10 Thread Paolo Bonzini
The last two arguments to these functions are the last and first bit to check relative to the base. The code was using incorrectly the first bit and the number of bits. Fix this in cpu_physical_memory_get_dirty and cpu_physical_memory_all_dirty. This requires a few changes in the iteration;

Re: [Qemu-devel] [PATCH] memory: fix usage of find_next_bit and find_next_zero_bit

2016-02-10 Thread Stefan Hajnoczi
On Wed, Feb 10, 2016 at 03:11:45PM +0100, Paolo Bonzini wrote: > The last two arguments to these functions are the last and first bit to > check relative to the base. The code was using incorrectly the first > bit and the number of bits. Fix this in cpu_physical_memory_get_dirty > and

Re: [Qemu-devel] [PATCH] memory: fix usage of find_next_bit and find_next_zero_bit

2016-02-10 Thread Thomas Huth
On 10.02.2016 15:11, Paolo Bonzini wrote: > The last two arguments to these functions are the last and first bit to > check relative to the base. The code was using incorrectly the first > bit and the number of bits. Fix this in cpu_physical_memory_get_dirty > and cpu_physical_memory_all_dirty.

Re: [Qemu-devel] [PATCH] memory: fix usage of find_next_bit and find_next_zero_bit

2016-02-10 Thread Leon Alrae
On 10/02/16 14:11, Paolo Bonzini wrote: > The last two arguments to these functions are the last and first bit to > check relative to the base. The code was using incorrectly the first > bit and the number of bits. Fix this in cpu_physical_memory_get_dirty > and cpu_physical_memory_all_dirty.

Re: [Qemu-devel] [PATCH] memory: fix usage of find_next_bit and find_next_zero_bit

2016-02-10 Thread Peter Maydell
On 10 February 2016 at 14:11, Paolo Bonzini wrote: > The last two arguments to these functions are the last and first bit to > check relative to the base. The code was using incorrectly the first > bit and the number of bits. Fix this in cpu_physical_memory_get_dirty > and