Re: [Qemu-devel] [PATCH] migration/colo.c: Fix compilation issue when disable replication

2018-10-31 Thread Zhang Chen
On Wed, Oct 31, 2018 at 3:54 AM Dr. David Alan Gilbert wrote: > * Zhang Chen (zhangc...@gmail.com) wrote: > > This compilation issue will occur when user use --disable-replication > > to config Qemu. > > > > Reported-by: Thomas Huth > > Signed-off-by: Zhang Chen > > OK; do we need to add a chec

Re: [Qemu-devel] [PATCH] migration/colo.c: Fix compilation issue when disable replication

2018-10-31 Thread Zhang Chen
On Thu, Nov 1, 2018 at 12:47 AM Dr. David Alan Gilbert wrote: > * Dr. David Alan Gilbert (dgilb...@redhat.com) wrote: > > * Zhang Chen (zhangc...@gmail.com) wrote: > > > This compilation issue will occur when user use --disable-replication > > > to config Qemu. > > > > > > Reported-by: Thomas Hut

Re: [Qemu-devel] [PATCH] migration/colo.c: Fix compilation issue when disable replication

2018-10-31 Thread Dr. David Alan Gilbert
* Dr. David Alan Gilbert (dgilb...@redhat.com) wrote: > * Zhang Chen (zhangc...@gmail.com) wrote: > > This compilation issue will occur when user use --disable-replication > > to config Qemu. > > > > Reported-by: Thomas Huth > > Signed-off-by: Zhang Chen > > Queued. Unqueued; this still isn't

Re: [Qemu-devel] [PATCH] migration/colo.c: Fix compilation issue when disable replication

2018-10-30 Thread Dr. David Alan Gilbert
* Zhang Chen (zhangc...@gmail.com) wrote: > This compilation issue will occur when user use --disable-replication > to config Qemu. > > Reported-by: Thomas Huth > Signed-off-by: Zhang Chen OK; do we need to add a check to migrate_caps_check to stop you enabling colo in this case? Reviewed-by:

Re: [Qemu-devel] [PATCH] migration/colo.c: Fix compilation issue when disable replication

2018-10-30 Thread Dr. David Alan Gilbert
* Zhang Chen (zhangc...@gmail.com) wrote: > This compilation issue will occur when user use --disable-replication > to config Qemu. > > Reported-by: Thomas Huth > Signed-off-by: Zhang Chen Queued. > --- > migration/colo.c | 18 +- > 1 file changed, 17 insertions(+), 1 deletion

[Qemu-devel] [PATCH] migration/colo.c: Fix compilation issue when disable replication

2018-10-24 Thread Zhang Chen
This compilation issue will occur when user use --disable-replication to config Qemu. Reported-by: Thomas Huth Signed-off-by: Zhang Chen --- migration/colo.c | 18 +- 1 file changed, 17 insertions(+), 1 deletion(-) diff --git a/migration/colo.c b/migration/colo.c index 956ac236