Re: [Qemu-devel] [PATCH] migration: Cleanup during exit

2019-03-03 Thread Peter Xu
On Fri, Mar 01, 2019 at 10:11:42AM +, Dr. David Alan Gilbert wrote: > * Peter Xu (pet...@redhat.com) wrote: > > On Thu, Feb 28, 2019 at 12:28:22PM +, Dr. David Alan Gilbert wrote: > > > * Daniel P. Berrangé (berra...@redhat.com) wrote: > > > > On Thu, Feb 28, 2019 at 11:40:19AM +, Dr.

Re: [Qemu-devel] [PATCH] migration: Cleanup during exit

2019-03-01 Thread Dr. David Alan Gilbert
* Peter Xu (pet...@redhat.com) wrote: > On Thu, Feb 28, 2019 at 12:28:22PM +, Dr. David Alan Gilbert wrote: > > * Daniel P. Berrangé (berra...@redhat.com) wrote: > > > On Thu, Feb 28, 2019 at 11:40:19AM +, Dr. David Alan Gilbert wrote: > > > > * Peter Xu (pet...@redhat.com) wrote: > > > >

Re: [Qemu-devel] [PATCH] migration: Cleanup during exit

2019-02-28 Thread Peter Xu
On Thu, Feb 28, 2019 at 12:28:22PM +, Dr. David Alan Gilbert wrote: > * Daniel P. Berrangé (berra...@redhat.com) wrote: > > On Thu, Feb 28, 2019 at 11:40:19AM +, Dr. David Alan Gilbert wrote: > > > * Peter Xu (pet...@redhat.com) wrote: > > > > On Wed, Feb 27, 2019 at 04:49:00PM +, Dr.

Re: [Qemu-devel] [PATCH] migration: Cleanup during exit

2019-02-28 Thread Dr. David Alan Gilbert
* Daniel P. Berrangé (berra...@redhat.com) wrote: > On Thu, Feb 28, 2019 at 11:40:19AM +, Dr. David Alan Gilbert wrote: > > * Peter Xu (pet...@redhat.com) wrote: > > > On Wed, Feb 27, 2019 at 04:49:00PM +, Dr. David Alan Gilbert (git) > > > wrote: > > > > From: "Dr. David Alan Gilbert" >

Re: [Qemu-devel] [PATCH] migration: Cleanup during exit

2019-02-28 Thread Daniel P . Berrangé
On Thu, Feb 28, 2019 at 11:40:19AM +, Dr. David Alan Gilbert wrote: > * Peter Xu (pet...@redhat.com) wrote: > > On Wed, Feb 27, 2019 at 04:49:00PM +, Dr. David Alan Gilbert (git) > > wrote: > > > From: "Dr. David Alan Gilbert" > > > > > > Currently we cleanup the migration object as we

Re: [Qemu-devel] [PATCH] migration: Cleanup during exit

2019-02-28 Thread Dr. David Alan Gilbert
* Peter Xu (pet...@redhat.com) wrote: > On Wed, Feb 27, 2019 at 04:49:00PM +, Dr. David Alan Gilbert (git) wrote: > > From: "Dr. David Alan Gilbert" > > > > Currently we cleanup the migration object as we exit main after the > > main_loop finishes; however if there's a migration running

Re: [Qemu-devel] [PATCH] migration: Cleanup during exit

2019-02-28 Thread Alex Bennée
Dr. David Alan Gilbert (git) writes: > From: "Dr. David Alan Gilbert" > > Currently we cleanup the migration object as we exit main after the > main_loop finishes; however if there's a migration running things > get messy and we can end up with the migration thread still trying > to access

Re: [Qemu-devel] [PATCH] migration: Cleanup during exit

2019-02-27 Thread Peter Xu
On Wed, Feb 27, 2019 at 04:49:00PM +, Dr. David Alan Gilbert (git) wrote: > From: "Dr. David Alan Gilbert" > > Currently we cleanup the migration object as we exit main after the > main_loop finishes; however if there's a migration running things > get messy and we can end up with the

Re: [Qemu-devel] [PATCH] migration: Cleanup during exit

2019-02-27 Thread Juan Quintela
"Dr. David Alan Gilbert (git)" wrote: > From: "Dr. David Alan Gilbert" > > Currently we cleanup the migration object as we exit main after the > main_loop finishes; however if there's a migration running things > get messy and we can end up with the migration thread still trying > to access

[Qemu-devel] [PATCH] migration: Cleanup during exit

2019-02-27 Thread Dr. David Alan Gilbert (git)
From: "Dr. David Alan Gilbert" Currently we cleanup the migration object as we exit main after the main_loop finishes; however if there's a migration running things get messy and we can end up with the migration thread still trying to access freed structures. We now take a ref to the object