Re: [Qemu-devel] [PATCH] migration: Fix seg with missing port

2016-09-15 Thread Paolo Bonzini
On 12/09/2016 21:03, Dr. David Alan Gilbert (git) wrote: > SocketAddress *saddr = tcp_build_address(host_port, errp); > -socket_start_outgoing_migration(s, saddr, errp); > +if (!*errp) { > +socket_start_outgoing_migration(s, saddr, errp); > +} > } > > void

Re: [Qemu-devel] [PATCH] migration: Fix seg with missing port

2016-09-12 Thread Eric Blake
On 09/12/2016 02:11 PM, Daniel P. Berrange wrote: > On Mon, Sep 12, 2016 at 08:03:54PM +0100, Dr. David Alan Gilbert (git) wrote: >> From: "Dr. David Alan Gilbert" >> >> The command : >>migrate tcp:localhost: >> >>currently segs; fix it so it now says: >> >>error

Re: [Qemu-devel] [PATCH] migration: Fix seg with missing port

2016-09-12 Thread Daniel P. Berrange
On Mon, Sep 12, 2016 at 08:03:54PM +0100, Dr. David Alan Gilbert (git) wrote: > From: "Dr. David Alan Gilbert" > > The command : >migrate tcp:localhost: > >currently segs; fix it so it now says: > >error parsing address 'localhost:' > > and the same for

[Qemu-devel] [PATCH] migration: Fix seg with missing port

2016-09-12 Thread Dr. David Alan Gilbert (git)
From: "Dr. David Alan Gilbert" The command : migrate tcp:localhost: currently segs; fix it so it now says: error parsing address 'localhost:' and the same for -incoming. (We know that errp is non-null; callers use a local_err). Signed-off-by: Dr. David Alan