[Qemu-devel] [PATCH] migration: Fix use-after-free during process exit

2019-04-08 Thread Yury Kotov
It fixes heap-use-after-free which was found by clang's ASAN. Control flow of this use-after-free: main_thread: * Got SIGTERM and completes main loop * Calls migration_shutdown - migrate_fd_cancel (so, migration_thread begins to complete) - object_unref(OBJECT(current_migration

Re: [Qemu-devel] [PATCH] migration: Fix use-after-free during process exit

2019-09-13 Thread Yury Kotov
Hi Vladimir! 13.09.2019, 16:43, "Vladimir Sementsov-Ogievskiy" : > Hi! > > 08.04.2019 14:33, Yury Kotov wrote: >>  It fixes heap-use-after-free which was found by clang's ASAN. >> >>  Control flow of this use-after-free: >>  main_thread: >>   * Got SIGTERM and completes main loop >>   * Ca

Re: [Qemu-devel] [PATCH] migration: Fix use-after-free during process exit

2019-09-13 Thread Vladimir Sementsov-Ogievskiy
Hi! 08.04.2019 14:33, Yury Kotov wrote: > It fixes heap-use-after-free which was found by clang's ASAN. > > Control flow of this use-after-free: > main_thread: > * Got SIGTERM and completes main loop > * Calls migration_shutdown >- migrate_fd_cancel (so, migration_thread begins

Re: [Qemu-devel] [PATCH] migration: Fix use-after-free during process exit

2019-04-17 Thread Yury Kotov
Ping 08.04.2019, 14:34, "Yury Kotov" : > It fixes heap-use-after-free which was found by clang's ASAN. > > Control flow of this use-after-free: > main_thread: > * Got SIGTERM and completes main loop > * Calls migration_shutdown >   - migrate_fd_cancel (so, migration_thread begins to co

Re: [Qemu-devel] [PATCH] migration: Fix use-after-free during process exit

2019-05-14 Thread Yury Kotov
Ping ping 17.04.2019, 15:44, "Yury Kotov" : > Ping > > 08.04.2019, 14:34, "Yury Kotov" : >>  It fixes heap-use-after-free which was found by clang's ASAN. >> >>  Control flow of this use-after-free: >>  main_thread: >>  * Got SIGTERM and completes main loop >>  * Calls migration_shutdown >

Re: [Qemu-devel] [PATCH] migration: Fix use-after-free during process exit

2019-05-14 Thread Dr. David Alan Gilbert
* Yury Kotov (yury-ko...@yandex-team.ru) wrote: > It fixes heap-use-after-free which was found by clang's ASAN. Reviewed-by: Dr. David Alan Gilbert and queued. (cc'ing in Stefan since aio crashes often get to him). > Control flow of this use-after-free: > main_thread: > * Got SIGTERM and c