Re: [Qemu-devel] [PATCH] migration: Introduce migration_in_completion()

2015-10-29 Thread Juan Quintela
Pavel Fedin wrote: > Hello! > >> ok, your problem here is that you modify ram. Could you take a look at >> how vhost manage this? It is done at migration_bitmap_sync(), and it >> just marks the pages that are dirty. > > Hm, interesting... I see it hooks into > memory_region_sync_dirty_bitmap()

Re: [Qemu-devel] [PATCH] migration: Introduce migration_in_completion()

2015-10-29 Thread Pavel Fedin
Hello! > ok, your problem here is that you modify ram. Could you take a look at > how vhost manage this? It is done at migration_bitmap_sync(), and it > just marks the pages that are dirty. Hm, interesting... I see it hooks into memory_region_sync_dirty_bitmap(). Sorry for maybe lame questio

Re: [Qemu-devel] [PATCH] migration: Introduce migration_in_completion()

2015-10-29 Thread Juan Quintela
Pavel Fedin wrote: > Hello! > >> Power people have a similar problem with its hashed page tables, they >> integrated their own save_live implementation because they are too big >> for the last stage. You can look there for inspiration. > > I examined their code. Interesting, and, indeed, it ope

Re: [Qemu-devel] [PATCH] migration: Introduce migration_in_completion()

2015-10-28 Thread Pavel Fedin
Hello! > Power people have a similar problem with its hashed page tables, they > integrated their own save_live implementation because they are too big > for the last stage. You can look there for inspiration. I examined their code. Interesting, and, indeed, it opens up a way for decreasing d

Re: [Qemu-devel] [PATCH] migration: Introduce migration_in_completion()

2015-10-28 Thread Pavel Fedin
Hello! > Power people have a similar problem with its hashed page tables, they > integrated their own save_live implementation because they are too big > for the last stage. You can look there for inspiration. Hm, i'll take a look... > How big are we talking here? Tables are normally large

Re: [Qemu-devel] [PATCH] migration: Introduce migration_in_completion()

2015-10-28 Thread Juan Quintela
Pavel Fedin wrote: > Hello! > >> Applied, thanks. > > Thank you. > >> I wonder who it has never been needed before. BTW, what is ITS? > > ITS is Interrupt Translation Service. It is used by ARM64 > architecture. In a short, it is a special hardware which performs > table-based lookup of MSI ID

Re: [Qemu-devel] [PATCH] migration: Introduce migration_in_completion()

2015-10-27 Thread Pavel Fedin
Hello! > Applied, thanks. Thank you. > I wonder who it has never been needed before. BTW, what is ITS? ITS is Interrupt Translation Service. It is used by ARM64 architecture. In a short, it is a special hardware which performs table-based lookup of MSI IDs and their destination CPUs, and r

Re: [Qemu-devel] [PATCH] migration: Introduce migration_in_completion()

2015-10-27 Thread Juan Quintela
Pavel Fedin wrote: > This allows to signal migration notifiers that the migration has entered > final phase. The condition is set after vm_stop_force_state(). > > This will be necessary for ITS live migration on ARM, which will have to > dump its state into guest RAM at this point. > > Signed-off-

[Qemu-devel] [PATCH] migration: Introduce migration_in_completion()

2015-10-27 Thread Pavel Fedin
This allows to signal migration notifiers that the migration has entered final phase. The condition is set after vm_stop_force_state(). This will be necessary for ITS live migration on ARM, which will have to dump its state into guest RAM at this point. Signed-off-by: Pavel Fedin --- include/mi