Re: [Qemu-devel] [PATCH] migration: Use RunState enum to save global state pre migrate

2019-06-25 Thread Maxiwell S. Garcia
On Tue, Jun 25, 2019 at 11:18:00AM +0100, Dr. David Alan Gilbert wrote: > * Maxiwell S. Garcia (maxiw...@linux.ibm.com) wrote: > > The GlobalState struct has two confusing fields: > > - uint8_t runstate[100] > > - RunState state > > > > The first field saves the 'current_run_state' from vl.c file

Re: [Qemu-devel] [PATCH] migration: Use RunState enum to save global state pre migrate

2019-06-25 Thread Philippe Mathieu-Daudé
Hi Dave, On 6/25/19 12:18 PM, Dr. David Alan Gilbert wrote: > * Maxiwell S. Garcia (maxiw...@linux.ibm.com) wrote: >> The GlobalState struct has two confusing fields: >> - uint8_t runstate[100] >> - RunState state >> >> The first field saves the 'current_run_state' from vl.c file before >> migrate

Re: [Qemu-devel] [PATCH] migration: Use RunState enum to save global state pre migrate

2019-06-25 Thread Dr. David Alan Gilbert
* Maxiwell S. Garcia (maxiw...@linux.ibm.com) wrote: > The GlobalState struct has two confusing fields: > - uint8_t runstate[100] > - RunState state > > The first field saves the 'current_run_state' from vl.c file before > migrate. The second field is filled in the post load func using the > 'runs

[Qemu-devel] [PATCH] migration: Use RunState enum to save global state pre migrate

2019-06-24 Thread Maxiwell S. Garcia
The GlobalState struct has two confusing fields: - uint8_t runstate[100] - RunState state The first field saves the 'current_run_state' from vl.c file before migrate. The second field is filled in the post load func using the 'runstate' value. So, this commit renames the 'runstate' to 'state_pre_m