Re: [Qemu-devel] [PATCH] migration: equation is more proper than and to check LOADVM_QUIT

2019-08-07 Thread Dr. David Alan Gilbert
* Wei Yang (richardw.y...@linux.intel.com) wrote: > LOADVM_QUIT allows a command to quit all layers of nested loadvm loops, > while current return value check is not that proper even it works now. > > Current return value check "ret & LOADVM_QUIT" would return true if > bit[0] is 1. This would be

Re: [Qemu-devel] [PATCH] migration: equation is more proper than and to check LOADVM_QUIT

2019-07-19 Thread Wei Yang
On Fri, Jul 19, 2019 at 07:41:28PM +0100, Dr. David Alan Gilbert wrote: >* Wei Yang (richardw.y...@linux.intel.com) wrote: >> LOADVM_QUIT allows a command to quit all layers of nested loadvm loops, >> while current return value check is not that proper even it works now. >> >> Current return value

Re: [Qemu-devel] [PATCH] migration: equation is more proper than and to check LOADVM_QUIT

2019-07-19 Thread Dr. David Alan Gilbert
* Wei Yang (richardw.y...@linux.intel.com) wrote: > LOADVM_QUIT allows a command to quit all layers of nested loadvm loops, > while current return value check is not that proper even it works now. > > Current return value check "ret & LOADVM_QUIT" would return true if > bit[0] is 1. This would be

[Qemu-devel] [PATCH] migration: equation is more proper than and to check LOADVM_QUIT

2019-07-17 Thread Wei Yang
LOADVM_QUIT allows a command to quit all layers of nested loadvm loops, while current return value check is not that proper even it works now. Current return value check "ret & LOADVM_QUIT" would return true if bit[0] is 1. This would be true when ret is -1 which is used to indicate an error of ha