Re: [Qemu-devel] [PATCH] migration: Fix rate limiting issue on RDMA migration

2018-03-23 Thread Dr. David Alan Gilbert
* Lidong Chen (jemmy858...@gmail.com) wrote: > RDMA migration implement save_page function for QEMUFile, but > ram_control_save_page do not increase bytes_xfer. So when doing > RDMA migration, it will use whole bandwidth. > > Signed-off-by: Lidong Chen Queued > --- > migration/qemu-file.c | 2

Re: [Qemu-devel] [PATCH] migration: Fix rate limiting issue on RDMA migration

2018-03-22 Thread 858585 jemmy
On Wed, Mar 21, 2018 at 2:19 AM, Juan Quintela wrote: > Lidong Chen wrote: >> RDMA migration implement save_page function for QEMUFile, but >> ram_control_save_page do not increase bytes_xfer. So when doing >> RDMA migration, it will use whole bandwidth. >> >> Signed-off-by: Lidong Chen > > Revi

Re: [Qemu-devel] [PATCH] migration: Fix rate limiting issue on RDMA migration

2018-03-20 Thread Juan Quintela
Lidong Chen wrote: > RDMA migration implement save_page function for QEMUFile, but > ram_control_save_page do not increase bytes_xfer. So when doing > RDMA migration, it will use whole bandwidth. > > Signed-off-by: Lidong Chen Reviewed-by: Juan Quintela This part of the code is a mess. To ans

Re: [Qemu-devel] [PATCH] migration: Fix rate limiting issue on RDMA migration

2018-03-19 Thread 858585 jemmy
ping. On Thu, Mar 15, 2018 at 1:33 PM, 858585 jemmy wrote: > On Thu, Mar 15, 2018 at 4:19 AM, Dr. David Alan Gilbert > wrote: >> * Lidong Chen (jemmy858...@gmail.com) wrote: >>> RDMA migration implement save_page function for QEMUFile, but >>> ram_control_save_page do not increase bytes_xfer. So

Re: [Qemu-devel] [PATCH] migration: Fix rate limiting issue on RDMA migration

2018-03-14 Thread 858585 jemmy
On Thu, Mar 15, 2018 at 4:19 AM, Dr. David Alan Gilbert wrote: > * Lidong Chen (jemmy858...@gmail.com) wrote: >> RDMA migration implement save_page function for QEMUFile, but >> ram_control_save_page do not increase bytes_xfer. So when doing >> RDMA migration, it will use whole bandwidth. > > Hi,

Re: [Qemu-devel] [PATCH] migration: Fix rate limiting issue on RDMA migration

2018-03-14 Thread Dr. David Alan Gilbert
* Lidong Chen (jemmy858...@gmail.com) wrote: > RDMA migration implement save_page function for QEMUFile, but > ram_control_save_page do not increase bytes_xfer. So when doing > RDMA migration, it will use whole bandwidth. Hi, Thanks for this, > Signed-off-by: Lidong Chen > --- > migration/qem

Re: [Qemu-devel] [PATCH] migration: Fix rate limiting issue on RDMA migration

2018-03-13 Thread 858585 jemmy
Ping. On Sat, Mar 10, 2018 at 10:32 PM, Lidong Chen wrote: > RDMA migration implement save_page function for QEMUFile, but > ram_control_save_page do not increase bytes_xfer. So when doing > RDMA migration, it will use whole bandwidth. > > Signed-off-by: Lidong Chen > --- > migration/qemu-file.

[Qemu-devel] [PATCH] migration: Fix rate limiting issue on RDMA migration

2018-03-10 Thread Lidong Chen
RDMA migration implement save_page function for QEMUFile, but ram_control_save_page do not increase bytes_xfer. So when doing RDMA migration, it will use whole bandwidth. Signed-off-by: Lidong Chen --- migration/qemu-file.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/migr

Re: [Qemu-devel] [PATCH] migration: fix rate limiting

2012-11-20 Thread Juan Quintela
Paolo Bonzini wrote: > Il 20/11/2012 12:03, Juan Quintela ha scritto: >> This patch is wrong O;-) >> That don't mean that current code is right. >> >> We have 4 variables: >> - xfer_limit: how much we are allowed to send each 100ms (in bytes) >> - buffer_capacity: the size of the buffer that we a

Re: [Qemu-devel] [PATCH] migration: fix rate limiting

2012-11-20 Thread Paolo Bonzini
Il 20/11/2012 12:03, Juan Quintela ha scritto: > This patch is wrong O;-) > That don't mean that current code is right. > > We have 4 variables: > - xfer_limit: how much we are allowed to send each 100ms (in bytes) > - buffer_capacity: the size of the buffer that we are using > - buffer_size: the

Re: [Qemu-devel] [PATCH] migration: fix rate limiting

2012-11-20 Thread Juan Quintela
Paolo Bonzini wrote: > buffered_rate_limit is called to prevent the RAM migration callback > from putting too much data in the buffer. So it has to check against > the amount of data currently in the buffer, not against the amount > of data that has been transferred so far. > > s->bytes_xfer is u

[Qemu-devel] [PATCH] migration: fix rate limiting

2012-11-19 Thread Paolo Bonzini
buffered_rate_limit is called to prevent the RAM migration callback from putting too much data in the buffer. So it has to check against the amount of data currently in the buffer, not against the amount of data that has been transferred so far. s->bytes_xfer is used to communicate between succes