Re: [Qemu-devel] [PATCH] migration: remove register_savevm()

2017-05-25 Thread David Gibson
On Thu, May 25, 2017 at 09:00:25AM +0200, Juan Quintela wrote: > Laurent Vivier wrote: > D> We can replace the four remaining calls of register_savevm() by > > calls to register_savevm_live(). So we can remove the function and > > as we don't allocate anymore the ops pointer with g_new0() > > we d

Re: [Qemu-devel] [PATCH] migration: remove register_savevm()

2017-05-25 Thread Juan Quintela
Laurent Vivier wrote: D> We can replace the four remaining calls of register_savevm() by > calls to register_savevm_live(). So we can remove the function and > as we don't allocate anymore the ops pointer with g_new0() > we don't have to free it then. > > Signed-off-by: Laurent Vivier Reviewed-b

Re: [Qemu-devel] [PATCH] migration: remove register_savevm()

2017-05-24 Thread David Gibson
On Wed, May 24, 2017 at 02:10:48PM +0200, Laurent Vivier wrote: > We can replace the four remaining calls of register_savevm() by > calls to register_savevm_live(). So we can remove the function and > as we don't allocate anymore the ops pointer with g_new0() > we don't have to free it then. > > S

Re: [Qemu-devel] [PATCH] migration: remove register_savevm()

2017-05-24 Thread Cornelia Huck
On Wed, 24 May 2017 14:10:48 +0200 Laurent Vivier wrote: > We can replace the four remaining calls of register_savevm() by > calls to register_savevm_live(). So we can remove the function and > as we don't allocate anymore the ops pointer with g_new0() > we don't have to free it then. > > Signed

Re: [Qemu-devel] [PATCH] migration: remove register_savevm()

2017-05-24 Thread Dmitry Fleytman
> On 24 May 2017, at 15:10 PM, Laurent Vivier wrote: > > We can replace the four remaining calls of register_savevm() by > calls to register_savevm_live(). So we can remove the function and > as we don't allocate anymore the ops pointer with g_new0() > we don't have to free it then. > > Signed-

Re: [Qemu-devel] [PATCH] migration: remove register_savevm()

2017-05-24 Thread Samuel Thibault
Laurent Vivier, on mer. 24 mai 2017 14:10:48 +0200, wrote: > We can replace the four remaining calls of register_savevm() by > calls to register_savevm_live(). So we can remove the function and > as we don't allocate anymore the ops pointer with g_new0() > we don't have to free it then. > > Signed

[Qemu-devel] [PATCH] migration: remove register_savevm()

2017-05-24 Thread Laurent Vivier
We can replace the four remaining calls of register_savevm() by calls to register_savevm_live(). So we can remove the function and as we don't allocate anymore the ops pointer with g_new0() we don't have to free it then. Signed-off-by: Laurent Vivier --- hw/net/vmxnet3.c| 8 ++--