[Qemu-devel] [PATCH] migration: savevm: fix error code with migration blockers

2019-04-09 Thread Cole Robinson
The only caller that checks the error code is looking for != 0, so returning false is incorrect. Fixes: 5aaac467938 "migration: savevm: consult migration blockers" Signed-off-by: Cole Robinson --- migration/savevm.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/migration/s

Re: [Qemu-devel] [PATCH] migration: savevm: fix error code with migration blockers

2019-04-10 Thread Dr. David Alan Gilbert
* Cole Robinson (crobi...@redhat.com) wrote: > The only caller that checks the error code is looking for != 0, > so returning false is incorrect. > > Fixes: 5aaac467938 "migration: savevm: consult migration blockers" > > Signed-off-by: Cole Robinson Thanks, this was in 3.1.0 so isn't a 4.0 regr

Re: [Qemu-devel] [PATCH] migration: savevm: fix error code with migration blockers

2019-04-10 Thread Juan Quintela
Cole Robinson wrote: > The only caller that checks the error code is looking for != 0, > so returning false is incorrect. > > Fixes: 5aaac467938 "migration: savevm: consult migration blockers" > > Signed-off-by: Cole Robinson Reviewed-by: Juan Quintela

Re: [Qemu-devel] [PATCH] migration: savevm: fix error code with migration blockers

2019-05-14 Thread Dr. David Alan Gilbert
* Cole Robinson (crobi...@redhat.com) wrote: > The only caller that checks the error code is looking for != 0, > so returning false is incorrect. > > Fixes: 5aaac467938 "migration: savevm: consult migration blockers" > > Signed-off-by: Cole Robinson Queued > --- > migration/savevm.c | 2 +- >