Re: [Qemu-devel] [PATCH] mips: Correctly save/restore the FP flush-to-zero state

2014-12-05 Thread Maciej W. Rozycki
On Fri, 5 Dec 2014, Leon Alrae wrote: > > I gave it a thought before making this change and concluded it would be > > the lesser evil (plus loudly manifesting and easily correctable) if > > someone accidentally makes QEMU refuse to load older images where in > > fact no compatibility issue exi

Re: [Qemu-devel] [PATCH] mips: Correctly save/restore the FP flush-to-zero state

2014-12-05 Thread Leon Alrae
On 12/11/2014 18:58, Maciej W. Rozycki wrote: > On Wed, 12 Nov 2014, Peter Maydell wrote: > >>> @@ -208,12 +206,12 @@ int cpu_load(QEMUFile *f, void *opaque, >>> MIPSCPU *cpu = mips_env_get_cpu(env); >>> int i; >>> >>> -if (version_id < 3) { >>> +if (version_id != CPU_SAVE_VERSIO

Re: [Qemu-devel] [PATCH] mips: Correctly save/restore the FP flush-to-zero state

2014-11-12 Thread Maciej W. Rozycki
On Wed, 12 Nov 2014, Peter Maydell wrote: > > @@ -208,12 +206,12 @@ int cpu_load(QEMUFile *f, void *opaque, > > MIPSCPU *cpu = mips_env_get_cpu(env); > > int i; > > > > -if (version_id < 3) { > > +if (version_id != CPU_SAVE_VERSION) { > > return -EINVAL; > > } > >

Re: [Qemu-devel] [PATCH] mips: Correctly save/restore the FP flush-to-zero state

2014-11-12 Thread Peter Maydell
On 12 November 2014 16:07, Maciej W. Rozycki wrote: > Fix the FP state save/restore operations by saving the `flush_to_zero' > rather than the `float_detect_tininess' setting. There is no provision > for the latter in MIPS hardware, whereas the former is controlled by the > CP1.FCSR.FS bit. As a

[Qemu-devel] [PATCH] mips: Correctly save/restore the FP flush-to-zero state

2014-11-12 Thread Maciej W. Rozycki
Fix the FP state save/restore operations by saving the `flush_to_zero' rather than the `float_detect_tininess' setting. There is no provision for the latter in MIPS hardware, whereas the former is controlled by the CP1.FCSR.FS bit. As a result all the older saved state images are invalid as t