Re: [Qemu-devel] [PATCH] mirror: hold aio_context before bdrv_drain

2015-04-01 Thread Bin Wu
On 2015/4/1 16:19, Fam Zheng wrote: > On Wed, 04/01 12:42, Bin Wu wrote: >> From: Bin Wu > > What's the issue are you fixing? I think the coroutine already is running in > the AioContext of bs. > > Fam > In the current implementation of bdrv_drain, it should be placed in a critical section as

Re: [Qemu-devel] [PATCH] mirror: hold aio_context before bdrv_drain

2015-04-01 Thread Fam Zheng
On Wed, 04/01 12:42, Bin Wu wrote: > From: Bin Wu What's the issue are you fixing? I think the coroutine already is running in the AioContext of bs. Fam > > Signed-off-by: Bin Wu > --- > block/mirror.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/block/mirror.c b/block/mirror.

[Qemu-devel] [PATCH] mirror: hold aio_context before bdrv_drain

2015-03-31 Thread Bin Wu
From: Bin Wu Signed-off-by: Bin Wu --- block/mirror.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/block/mirror.c b/block/mirror.c index 4056164..08372df 100644 --- a/block/mirror.c +++ b/block/mirror.c @@ -530,7 +530,9 @@ static void coroutine_fn mirror_run(void *opaque)