Re: [Qemu-devel] [PATCH] misc: zynq_slcr: Fix MMIO writes

2015-10-13 Thread Peter Maydell
On 10 October 2015 at 03:53, Peter Crosthwaite wrote: > The /4 for offset calculation in MMIO writes was happening twice giving > wrong write offsets. Fix. > > While touching the code, change the if-else to be a short returning if > and convert the debug message to a GUEST_ERROR, which is more acc

Re: [Qemu-devel] [PATCH] misc: zynq_slcr: Fix MMIO writes

2015-10-12 Thread Alistair Francis
On Fri, Oct 9, 2015 at 7:53 PM, Peter Crosthwaite wrote: > The /4 for offset calculation in MMIO writes was happening twice giving > wrong write offsets. Fix. > > While touching the code, change the if-else to be a short returning if > and convert the debug message to a GUEST_ERROR, which is more

[Qemu-devel] [PATCH] misc: zynq_slcr: Fix MMIO writes

2015-10-09 Thread Peter Crosthwaite
The /4 for offset calculation in MMIO writes was happening twice giving wrong write offsets. Fix. While touching the code, change the if-else to be a short returning if and convert the debug message to a GUEST_ERROR, which is more accurate for this condition. Cc: qemu-sta...@nongnu.org Cc: Guente