Re: [Qemu-devel] [PATCH] modules-test: fix const cast

2019-08-27 Thread Peter Maydell
On Tue, 27 Aug 2019 at 14:39, Marc-André Lureau wrote: > > Hi > > On Tue, Aug 27, 2019 at 4:02 PM Peter Maydell > wrote: > > > > On Fri, 23 Aug 2019 at 13:10, Paolo Bonzini wrote: > > > > > > On 23/08/19 14:07, Peter Maydell wrote: > > > >> Are you going to apply this and "[PATCH]

Re: [Qemu-devel] [PATCH] modules-test: fix const cast

2019-08-27 Thread Marc-André Lureau
Hi On Tue, Aug 27, 2019 at 4:02 PM Peter Maydell wrote: > > On Fri, 23 Aug 2019 at 13:10, Paolo Bonzini wrote: > > > > On 23/08/19 14:07, Peter Maydell wrote: > > >> Are you going to apply this and "[PATCH] modules-test: ui-spice-app is > > >> not built as module" to qemu.git directly? > > > Is

Re: [Qemu-devel] [PATCH] modules-test: fix const cast

2019-08-27 Thread Peter Maydell
On Fri, 23 Aug 2019 at 13:10, Paolo Bonzini wrote: > > On 23/08/19 14:07, Peter Maydell wrote: > >> Are you going to apply this and "[PATCH] modules-test: ui-spice-app is > >> not built as module" to qemu.git directly? > > Is the other one also needed as a build fix ? > > Yes, otherwise the test

Re: [Qemu-devel] [PATCH] modules-test: fix const cast

2019-08-23 Thread Peter Maydell
On Thu, 22 Aug 2019 at 18:42, Paolo Bonzini wrote: > > Signed-off-by: Paolo Bonzini > --- > tests/modules-test.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/tests/modules-test.c b/tests/modules-test.c > index 3aef0e5..a8118e9 100644 > --- a/tests/modules-test.c >

Re: [Qemu-devel] [PATCH] modules-test: fix const cast

2019-08-23 Thread Miroslav Rezanina
On Thu, Aug 22, 2019 at 07:42:13PM +0200, Paolo Bonzini wrote: > Signed-off-by: Paolo Bonzini > --- > tests/modules-test.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/tests/modules-test.c b/tests/modules-test.c > index 3aef0e5..a8118e9 100644 > ---

Re: [Qemu-devel] [PATCH] modules-test: fix const cast

2019-08-23 Thread Thomas Huth
On 8/23/19 2:10 PM, Paolo Bonzini wrote: > On 23/08/19 14:07, Peter Maydell wrote: >>> Are you going to apply this and "[PATCH] modules-test: ui-spice-app is >>> not built as module" to qemu.git directly? >> Is the other one also needed as a build fix ? > > Yes, otherwise the test fails (it

Re: [Qemu-devel] [PATCH] modules-test: fix const cast

2019-08-23 Thread Paolo Bonzini
On 23/08/19 14:07, Peter Maydell wrote: >> Are you going to apply this and "[PATCH] modules-test: ui-spice-app is >> not built as module" to qemu.git directly? > Is the other one also needed as a build fix ? Yes, otherwise the test fails (it didn't fail in the meson tree). > I was planning to

Re: [Qemu-devel] [PATCH] modules-test: fix const cast

2019-08-23 Thread Peter Maydell
On Fri, 23 Aug 2019 at 13:04, Paolo Bonzini wrote: > > On 23/08/19 11:11, Peter Maydell wrote: > > On Fri, 23 Aug 2019 at 10:06, Thomas Huth wrote: > >> > >> On 8/22/19 7:42 PM, Paolo Bonzini wrote: > >>> Signed-off-by: Paolo Bonzini > >>> --- > >>> tests/modules-test.c | 2 +- > >>> 1 file

Re: [Qemu-devel] [PATCH] modules-test: fix const cast

2019-08-23 Thread Paolo Bonzini
On 23/08/19 11:11, Peter Maydell wrote: > On Fri, 23 Aug 2019 at 10:06, Thomas Huth wrote: >> >> On 8/22/19 7:42 PM, Paolo Bonzini wrote: >>> Signed-off-by: Paolo Bonzini >>> --- >>> tests/modules-test.c | 2 +- >>> 1 file changed, 1 insertion(+), 1 deletion(-) >>> >>> diff --git

Re: [Qemu-devel] [PATCH] modules-test: fix const cast

2019-08-23 Thread Peter Maydell
On Fri, 23 Aug 2019 at 10:06, Thomas Huth wrote: > > On 8/22/19 7:42 PM, Paolo Bonzini wrote: > > Signed-off-by: Paolo Bonzini > > --- > > tests/modules-test.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/tests/modules-test.c b/tests/modules-test.c > > index

Re: [Qemu-devel] [PATCH] modules-test: fix const cast

2019-08-23 Thread Thomas Huth
On 8/22/19 7:42 PM, Paolo Bonzini wrote: > Signed-off-by: Paolo Bonzini > --- > tests/modules-test.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/tests/modules-test.c b/tests/modules-test.c > index 3aef0e5..a8118e9 100644 > --- a/tests/modules-test.c > +++

Re: [Qemu-devel] [PATCH] modules-test: fix const cast

2019-08-23 Thread Marc-André Lureau
On Thu, Aug 22, 2019 at 9:42 PM Paolo Bonzini wrote: > > Signed-off-by: Paolo Bonzini Reviewed-by: Marc-André Lureau > --- > tests/modules-test.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/tests/modules-test.c b/tests/modules-test.c > index 3aef0e5..a8118e9

[Qemu-devel] [PATCH] modules-test: fix const cast

2019-08-22 Thread Paolo Bonzini
Signed-off-by: Paolo Bonzini --- tests/modules-test.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests/modules-test.c b/tests/modules-test.c index 3aef0e5..a8118e9 100644 --- a/tests/modules-test.c +++ b/tests/modules-test.c @@ -4,7 +4,7 @@ static void