Re: [Qemu-devel] [PATCH] monitor: Add force option support to pci_del command

2010-06-17 Thread Anthony Liguori
On 06/17/2010 01:15 PM, Luiz Capitulino wrote: This is a general question for all commands that can take way too long or never return. For QMP the question is whether we should handle this in QEMU or in the client. Ie, if the guest doesn't respond the client could detect that and cancel the

Re: [Qemu-devel] [PATCH] monitor: Add force option support to pci_del command

2010-06-17 Thread Luiz Capitulino
On Tue, 15 Jun 2010 11:03:13 +0200 Markus Armbruster wrote: > Anthony Liguori writes: > > > On 06/09/2010 09:27 AM, Gerd Hoffmann wrote: > >> Hi, > >> > >>> This make sense when you mistakenly add a pci device on a -s -S > >>> scenario, like the scenario described on the following bug: > >>>

Re: [Qemu-devel] [PATCH] monitor: Add force option support to pci_del command

2010-06-15 Thread Markus Armbruster
Anthony Liguori writes: > On 06/09/2010 09:27 AM, Gerd Hoffmann wrote: >> Hi, >> >>> This make sense when you mistakenly add a pci device on a -s -S >>> scenario, like the scenario described on the following bug: >>> https://bugs.launchpad.net/qemu/+bug/544367. >> >> It doesn't IMHO. >> >>> Whe

Re: [Qemu-devel] [PATCH] monitor: Add force option support to pci_del command

2010-06-15 Thread Gerd Hoffmann
Hi, If the guest is stopped while unplugging the device the unplug should happen as soon as the guest is unpaused. This is a case where the fundamental problem is that the pci_del command should block until the guest has actually responded to the request. You can't block. Unplug might nev

Re: [Qemu-devel] [PATCH] monitor: Add force option support to pci_del command

2010-06-14 Thread Anthony Liguori
On 06/09/2010 09:27 AM, Gerd Hoffmann wrote: Hi, This make sense when you mistakenly add a pci device on a -s -S scenario, like the scenario described on the following bug: https://bugs.launchpad.net/qemu/+bug/544367. It doesn't IMHO. When ACPI-based hotplug support is present on the gues

Re: [Qemu-devel] [PATCH] monitor: Add force option support to pci_del command

2010-06-09 Thread Gerd Hoffmann
Hi, This make sense when you mistakenly add a pci device on a -s -S scenario, like the scenario described on the following bug: https://bugs.launchpad.net/qemu/+bug/544367. It doesn't IMHO. When ACPI-based hotplug support is present on the guest and we run pci_del with the force option, th

Re: [Qemu-devel] [PATCH] monitor: Add force option support to pci_del command

2010-06-09 Thread Marcos Oviedo
On Wed, Jun 9, 2010 at 4:38 AM, Gerd Hoffmann wrote: > On 06/09/10 07:37, Marcos Oviedo wrote: > >> This adds a way to force the removal/unplug of previously added pci >> devices when ACPI-based hotplug mechanism is not present. >> > > Point being? > > If your guest can't handle pci hotplug it is

Re: [Qemu-devel] [PATCH] monitor: Add force option support to pci_del command

2010-06-09 Thread Gerd Hoffmann
On 06/09/10 07:37, Marcos Oviedo wrote: This adds a way to force the removal/unplug of previously added pci devices when ACPI-based hotplug mechanism is not present. Point being? If your guest can't handle pci hotplug it is pretty useless to plug in hardware in the first place. If your gues

Re: [Qemu-devel] [PATCH] monitor: Add force option support to pci_del command

2010-06-08 Thread Markus Armbruster
Marcos Oviedo writes: > This adds a way to force the removal/unplug of previously added pci > devices when ACPI-based hotplug mechanism is not present. > > Signed-off-by: Marcos Oviedo If this makes sense for pci_del (I'm not passing judgement), then we need it for device_del as well.

[Qemu-devel] [PATCH] monitor: Add force option support to pci_del command

2010-06-08 Thread Marcos Oviedo
This adds a way to force the removal/unplug of previously added pci devices when ACPI-based hotplug mechanism is not present. Signed-off-by: Marcos Oviedo --- hw/pci-hotplug.c | 16 +--- qemu-monitor.hx |4 ++-- sysemu.h |2 +- 3 files changed, 16 insertions(+), 6