Re: [Qemu-devel] [PATCH] monitor: Add info qom-tree subcommand.

2014-05-11 Thread Hani Benhabiles
On Wed, May 07, 2014 at 05:39:36PM +0200, Andreas Färber wrote: > Hi Hani, > > Am 27.04.2014 12:29, schrieb Hani Benhabiles: > > Signed-off-by: Hani Benhabiles > > --- > > > > Not sure whether the qobject stringifying functions could fit or be of some > > use > > elsewhere. Thus, I kept them as

Re: [Qemu-devel] [PATCH] monitor: Add info qom-tree subcommand.

2014-05-11 Thread Hani Benhabiles
On Wed, May 07, 2014 at 01:01:12PM +0200, Paolo Bonzini wrote: > Il 05/05/2014 20:33, Luiz Capitulino ha scritto: > >>+data = object_property_get_qobject(obj, info->name, NULL); > >>+if (!data) { > >>+list = list->next; > >>+continue; > > You

Re: [Qemu-devel] [PATCH] monitor: Add info qom-tree subcommand.

2014-05-07 Thread Andreas Färber
Hi Hani, Am 27.04.2014 12:29, schrieb Hani Benhabiles: > Signed-off-by: Hani Benhabiles > --- > > Not sure whether the qobject stringifying functions could fit or be of some > use > elsewhere. Thus, I kept them as static near the only place where they are used > at the moment. Your "info qom-t

Re: [Qemu-devel] [PATCH] monitor: Add info qom-tree subcommand.

2014-05-07 Thread Paolo Bonzini
Il 05/05/2014 20:33, Luiz Capitulino ha scritto: +data = object_property_get_qobject(obj, info->name, NULL); +if (!data) { +list = list->next; +continue; You could use object_property_print and get rid of a relatively large amount of code

Re: [Qemu-devel] [PATCH] monitor: Add info qom-tree subcommand.

2014-05-05 Thread Luiz Capitulino
On Sun, 27 Apr 2014 11:29:30 +0100 Hani Benhabiles wrote: > Signed-off-by: Hani Benhabiles Who can review this one? I'm not familiar enough with QOM to do it. > --- > > Not sure whether the qobject stringifying functions could fit or be of some > use > elsewhere. Thus, I kept them as static

[Qemu-devel] [PATCH] monitor: Add info qom-tree subcommand.

2014-04-27 Thread Hani Benhabiles
Signed-off-by: Hani Benhabiles --- Not sure whether the qobject stringifying functions could fit or be of some use elsewhere. Thus, I kept them as static near the only place where they are used at the moment. hmp-commands.hx | 2 + hmp.c | 143 +++