Re: [Qemu-devel] [PATCH] monitor: avoid moving cursor during "mouse_button" command

2011-05-01 Thread Gerd Hoffmann
Hi, The problem is that almost all input code (in absolute mode) keeps track of the position itself - monitor was the exception. So a sequence like the following: 1. Move cursor in SDL 2. Use mouse_move in monitor 3. Use mouse_button 2 in monitor 4. Click mouse in SDL works ok up to step 3, b

Re: [Qemu-devel] [PATCH] monitor: avoid moving cursor during "mouse_button" command

2011-04-29 Thread Brad Hards
On Thursday 28 April 2011 20:46:25 Gerd Hoffmann wrote: > I think it would be much better to keep track of the mouse position (and > button state while being at it) in input.c instead of monitor.c. > > Once this is in place it should be easy to add kbd_mouse_* functions > which update position or

Re: [Qemu-devel] [PATCH] monitor: avoid moving cursor during "mouse_button" command

2011-04-28 Thread Gerd Hoffmann
On 04/08/11 18:37, Luiz Capitulino wrote: On Fri, 08 Apr 2011 16:34:21 +0200 Markus Armbruster wrote: Brad Hards writes: This addresses https://bugs.launchpad.net/qemu/+bug/752476 which basically points out that using the mouse_button command causes the mouse cursor to warp to the origin (w

Re: [Qemu-devel] [PATCH] monitor: avoid moving cursor during "mouse_button" command

2011-04-08 Thread Brad Hards
On Sat, 9 Apr 2011 12:34:21 am Markus Armbruster wrote: > There's one instance of state: position (if absolute) + buttons for any > number of mice. Funny things can happen when you have more than one > mouse and switch between them. For the common case (in most OS), each of the mice are mixed toge

Re: [Qemu-devel] [PATCH] monitor: avoid moving cursor during "mouse_button" command

2011-04-08 Thread Luiz Capitulino
On Fri, 08 Apr 2011 16:34:21 +0200 Markus Armbruster wrote: > Brad Hards writes: > > > This addresses https://bugs.launchpad.net/qemu/+bug/752476 which > > basically points out that using the mouse_button command causes > > the mouse cursor to warp to the origin (when using absolute > > pointin

Re: [Qemu-devel] [PATCH] monitor: avoid moving cursor during "mouse_button" command

2011-04-08 Thread Markus Armbruster
Brad Hards writes: > This addresses https://bugs.launchpad.net/qemu/+bug/752476 which > basically points out that using the mouse_button command causes > the mouse cursor to warp to the origin (when using absolute > pointing device). > > I've tested this with a kubuntu 10.10 guest and it works fi

Re: [Qemu-devel] [PATCH] monitor: avoid moving cursor during "mouse_button" command

2011-04-08 Thread Brad Hards
On Fri, 8 Apr 2011 05:44:00 pm Brad Hards wrote: > I've tested this with a kubuntu 10.10 guest and it works fine > for me with both relative and absolute pointing devices. Note > that testing with realtive pointing device was relatively > light. This fix (in slightly different form) was verified by

[Qemu-devel] [PATCH] monitor: avoid moving cursor during "mouse_button" command

2011-04-08 Thread Brad Hards
This addresses https://bugs.launchpad.net/qemu/+bug/752476 which basically points out that using the mouse_button command causes the mouse cursor to warp to the origin (when using absolute pointing device). I've tested this with a kubuntu 10.10 guest and it works fine for me with both relative and