Re: [Qemu-devel] [PATCH] monitor: report entirety of hmp command on error

2018-05-07 Thread Collin Walling
On 05/04/2018 02:19 PM, Eric Blake wrote: > On 05/04/2018 01:02 PM, Collin Walling wrote: > >>> So rather than trying to reconstruct a string, you could reuse what you >>> already have.  This is a shorter patch that I think accomplishes the same >>> goal: >>> >>> diff --git i/monitor.c

Re: [Qemu-devel] [PATCH] monitor: report entirety of hmp command on error

2018-05-04 Thread Eric Blake
On 05/04/2018 09:49 AM, Collin Walling wrote: When a user incorrectly provides an hmp command, an error response will be printed that prompts the user to try "help ". However, when the command contains multiple parts e.g. "info skeys", only the last whitespace delimited string will be reported

Re: [Qemu-devel] [PATCH] monitor: report entirety of hmp command on error

2018-05-04 Thread Eric Blake
On 05/04/2018 01:02 PM, Collin Walling wrote: So rather than trying to reconstruct a string, you could reuse what you already have.  This is a shorter patch that I think accomplishes the same goal: diff --git i/monitor.c w/monitor.c index 39f8ee17ba7..38736b3a20d 100644 --- i/monitor.c +++

Re: [Qemu-devel] [PATCH] monitor: report entirety of hmp command on error

2018-05-04 Thread Collin Walling
On 05/04/2018 11:19 AM, Eric Blake wrote: > On 05/04/2018 09:49 AM, Collin Walling wrote: >> When a user incorrectly provides an hmp command, an error response will be >> printed that prompts the user to try "help ". However, when >> the command contains multiple parts e.g. "info skeys", only the

Re: [Qemu-devel] [PATCH] monitor: report entirety of hmp command on error

2018-05-04 Thread Dr. David Alan Gilbert
* Eric Blake (ebl...@redhat.com) wrote: > On 05/04/2018 09:49 AM, Collin Walling wrote: > > When a user incorrectly provides an hmp command, an error response will be > > printed that prompts the user to try "help ". However, when > > the command contains multiple parts e.g. "info skeys", only the

Re: [Qemu-devel] [PATCH] monitor: report entirety of hmp command on error

2018-05-04 Thread Eric Blake
On 05/04/2018 09:49 AM, Collin Walling wrote: When a user incorrectly provides an hmp command, an error response will be printed that prompts the user to try "help ". However, when the command contains multiple parts e.g. "info skeys", only the last whitespace delimited string will be reported

[Qemu-devel] [PATCH] monitor: report entirety of hmp command on error

2018-05-04 Thread Collin Walling
When a user incorrectly provides an hmp command, an error response will be printed that prompts the user to try "help ". However, when the command contains multiple parts e.g. "info skeys", only the last whitespace delimited string will be reported (in this example "info" will be dropped and