Re: [Qemu-devel] [PATCH] msix: fix msix_vector_masked

2016-02-15 Thread Markus Armbruster
"Michael S. Tsirkin" writes: > commit 428c3ece97179557f2753071fb0ca97a03437267 ("fix MSI injection on Xen") > inadvertently enabled the xen-specific logic unconditionally. > Limit it to only when xen is enabled. > Additionally, msix data should be read with pci_get_log > since the format is pci l

Re: [Qemu-devel] [PATCH] msix: fix msix_vector_masked

2016-02-15 Thread Michael S. Tsirkin
On Mon, Feb 15, 2016 at 10:15:12AM +, Stefano Stabellini wrote: > On Sat, 13 Feb 2016, Michael S. Tsirkin wrote: > > commit 428c3ece97179557f2753071fb0ca97a03437267 ("fix MSI injection on Xen") > > inadvertently enabled the xen-specific logic unconditionally. > > Limit it to only when xen is en

Re: [Qemu-devel] [PATCH] msix: fix msix_vector_masked

2016-02-15 Thread Stefano Stabellini
On Sat, 13 Feb 2016, Michael S. Tsirkin wrote: > commit 428c3ece97179557f2753071fb0ca97a03437267 ("fix MSI injection on Xen") > inadvertently enabled the xen-specific logic unconditionally. > Limit it to only when xen is enabled. > Additionally, msix data should be read with pci_get_log > since the

[Qemu-devel] [PATCH] msix: fix msix_vector_masked

2016-02-13 Thread Michael S. Tsirkin
commit 428c3ece97179557f2753071fb0ca97a03437267 ("fix MSI injection on Xen") inadvertently enabled the xen-specific logic unconditionally. Limit it to only when xen is enabled. Additionally, msix data should be read with pci_get_log since the format is pci little-endian. Reported-by: "Daniel P. Be