Re: [Qemu-devel] [PATCH] nbd: Fully initialize client in case of failed negotiation

2017-06-09 Thread Eric Blake
On 05/26/2017 10:04 PM, Eric Blake wrote: > If a non-NBD client connects to qemu-nbd, we would end up with > a SIGSEGV in nbd_cilent_put() because we were trying to > unregister the client's association to the export, even though > we skipped inserting the client into that list. Easy trigger > in

Re: [Qemu-devel] [PATCH] nbd: Fully initialize client in case of failed negotiation

2017-05-29 Thread Eric Blake
On 05/26/2017 10:04 PM, Eric Blake wrote: > If a non-NBD client connects to qemu-nbd, we would end up with > a SIGSEGV in nbd_cilent_put() because we were trying to > unregister the client's association to the export, even though > we skipped inserting the client into that list. Easy trigger > in

[Qemu-devel] [PATCH] nbd: Fully initialize client in case of failed negotiation

2017-05-26 Thread Eric Blake
If a non-NBD client connects to qemu-nbd, we would end up with a SIGSEGV in nbd_cilent_put() because we were trying to unregister the client's association to the export, even though we skipped inserting the client into that list. Easy trigger in two terminals: $ qemu-nbd -p 30001 --format=raw fil