Re: [Qemu-devel] [PATCH] nbd: Implement NBD_CMD_HAS_ZERO_INIT

2016-12-05 Thread Fangyi (C)
I have already seen your proposal mail for NBD_FLAG_INIT_ZEROES extension. Thank you! 在 2016/12/6 0:54, Eric Blake 写道: On 12/05/2016 05:09 AM, Stefan Hajnoczi wrote: On Sun, Dec 04, 2016 at 11:44:57PM +, Yi Fang wrote: NBD client has not implemented callback for .bdrv_has_zero_init. So

Re: [Qemu-devel] [PATCH] nbd: Implement NBD_CMD_HAS_ZERO_INIT

2016-12-05 Thread Fangyi (C)
Yes, you are right. It's not necessary to use such a command. I will subscribe nbd-general mail-list and implement has_zero_init during connection. Thank you! 在 2016/12/5 19:09, Stefan Hajnoczi 写道: On Sun, Dec 04, 2016 at 11:44:57PM +, Yi Fang wrote: NBD client has not implemented

Re: [Qemu-devel] [PATCH] nbd: Implement NBD_CMD_HAS_ZERO_INIT

2016-12-05 Thread Eric Blake
On 12/05/2016 05:09 AM, Stefan Hajnoczi wrote: > On Sun, Dec 04, 2016 at 11:44:57PM +, Yi Fang wrote: >> NBD client has not implemented callback for .bdrv_has_zero_init. So >> bdrv_has_zero_init always returns 0 when doing non-shared storage >> migration. >> This patch implemented

Re: [Qemu-devel] [PATCH] nbd: Implement NBD_CMD_HAS_ZERO_INIT

2016-12-05 Thread Stefan Hajnoczi
On Sun, Dec 04, 2016 at 11:44:57PM +, Yi Fang wrote: > NBD client has not implemented callback for .bdrv_has_zero_init. So > bdrv_has_zero_init always returns 0 when doing non-shared storage > migration. > This patch implemented NBD_CMD_HAS_ZERO_INIT and will avoid unnecessary > set-dirty.

[Qemu-devel] [PATCH] nbd: Implement NBD_CMD_HAS_ZERO_INIT

2016-12-04 Thread Yi Fang
NBD client has not implemented callback for .bdrv_has_zero_init. So bdrv_has_zero_init always returns 0 when doing non-shared storage migration. This patch implemented NBD_CMD_HAS_ZERO_INIT and will avoid unnecessary set-dirty. Signed-off-by: Yi Fang ---