Re: [Qemu-devel] [PATCH] nbd: use client_close() when negotiate phase fails

2016-01-19 Thread Paolo Bonzini
On 19/01/2016 12:50, Daniel P. Berrange wrote: > When nbd_negotiate() fails, nbd_co_client_start() is > directly calling client->close(). This eventually > ends up calling nbd_client_put(), which does an > assert(client->closing). Unfortunately we have not > set the 'closing' flag, so the code no

[Qemu-devel] [PATCH] nbd: use client_close() when negotiate phase fails

2016-01-19 Thread Daniel P. Berrange
When nbd_negotiate() fails, nbd_co_client_start() is directly calling client->close(). This eventually ends up calling nbd_client_put(), which does an assert(client->closing). Unfortunately we have not set the 'closing' flag, so the code now aborts. This bug was accidentally introduced in commit