Re: [Qemu-devel] [PATCH] net/colo-compare.c: Fix memory leak and code style issue.

2019-07-04 Thread Zhang, Chen
> -Original Message- > From: Peter Maydell [mailto:peter.mayd...@linaro.org] > Sent: Wednesday, July 3, 2019 6:31 PM > To: Zhang, Chen > Cc: Li Zhijian ; Jason Wang ; > qemu-dev ; Zhang Chen > Subject: Re: [PATCH] net/colo-compare.c: Fix memory leak and code style issue. > > On Wed, 3

Re: [Qemu-devel] [PATCH] net/colo-compare.c: Fix memory leak and code style issue.

2019-07-03 Thread Zhang, Chen
> -Original Message- > From: Philippe Mathieu-Daudé [mailto:phi...@redhat.com] > Sent: Wednesday, July 3, 2019 4:56 PM > To: Zhang, Chen ; Li Zhijian ; > Peter Maydell ; Jason Wang > ; qemu-dev > Cc: Zhang Chen > Subject: Re: [Qemu-devel] [PATCH] net/colo-compar

Re: [Qemu-devel] [PATCH] net/colo-compare.c: Fix memory leak and code style issue.

2019-07-03 Thread Peter Maydell
On Wed, 3 Jul 2019 at 02:42, Zhang Chen wrote: > > From: Zhang Chen > > Address Peter's comments in patch "COLO-compare:Add colo-compare > remote notify support". > > Signed-off-by: Zhang Chen > --- > net/colo-compare.c | 13 ++--- > 1 file changed, 6 insertions(+), 7 deletions(-) > > d

Re: [Qemu-devel] [PATCH] net/colo-compare.c: Fix memory leak and code style issue.

2019-07-03 Thread no-reply
Patchew URL: https://patchew.org/QEMU/20190703013805.2722-1-chen.zh...@intel.com/ Hi, This series failed the asan build test. Please find the testing commands and their output below. If you have Docker installed, you can probably reproduce it locally. === TEST SCRIPT BEGIN === #!/bin/bash mak

Re: [Qemu-devel] [PATCH] net/colo-compare.c: Fix memory leak and code style issue.

2019-07-03 Thread Philippe Mathieu-Daudé
On 7/3/19 3:38 AM, Zhang Chen wrote: > From: Zhang Chen > > Address Peter's comments in patch "COLO-compare:Add colo-compare > remote notify support". This comment is not useful in the git history (no reference). You might reword him, use full coment, or simply: Reported-by: Coverity (CID 1402

Re: [Qemu-devel] [PATCH] net/colo-compare.c: Fix memory leak and code style issue.

2019-07-02 Thread no-reply
Patchew URL: https://patchew.org/QEMU/20190703013805.2722-1-chen.zh...@intel.com/ Hi, This series failed the asan build test. Please find the testing commands and their output below. If you have Docker installed, you can probably reproduce it locally. === TEST SCRIPT BEGIN === #!/bin/bash mak

[Qemu-devel] [PATCH] net/colo-compare.c: Fix memory leak and code style issue.

2019-07-02 Thread Zhang Chen
From: Zhang Chen Address Peter's comments in patch "COLO-compare:Add colo-compare remote notify support". Signed-off-by: Zhang Chen --- net/colo-compare.c | 13 ++--- 1 file changed, 6 insertions(+), 7 deletions(-) diff --git a/net/colo-compare.c b/net/colo-compare.c index 909dd6c6eb.