[Qemu-devel] [PATCH] net/net: Add ReadState for reuse codes

2016-05-06 Thread Zhang Chen
Signed-off-by: Zhang Chen Signed-off-by: Li Zhijian Signed-off-by: Wen Congyang --- include/net/net.h | 8 ++ net/filter-mirror.c | 60 net/net.c | 56 ++ net/socket.c| 71 +

Re: [Qemu-devel] [PATCH] net/net: Add ReadState for reuse codes

2016-05-09 Thread Li Zhijian
On 05/06/2016 06:56 PM, Zhang Chen wrote: Signed-off-by: Zhang Chen Signed-off-by: Li Zhijian Signed-off-by: Wen Congyang --- include/net/net.h | 8 ++ net/filter-mirror.c | 60 net/net.c | 56 +

Re: [Qemu-devel] [PATCH] net/net: Add ReadState for reuse codes

2016-05-09 Thread Zhang Chen
On 05/10/2016 10:57 AM, Li Zhijian wrote: On 05/06/2016 06:56 PM, Zhang Chen wrote: Signed-off-by: Zhang Chen Signed-off-by: Li Zhijian Signed-off-by: Wen Congyang --- include/net/net.h | 8 ++ net/filter-mirror.c | 60 net/net.c

Re: [Qemu-devel] [PATCH] net/net: Add ReadState for reuse codes

2016-05-11 Thread Zhang Chen
On 05/10/2016 10:57 AM, Li Zhijian wrote: On 05/06/2016 06:56 PM, Zhang Chen wrote: Signed-off-by: Zhang Chen Signed-off-by: Li Zhijian Signed-off-by: Wen Congyang --- include/net/net.h | 8 ++ net/filter-mirror.c | 60 net/net.c

Re: [Qemu-devel] [PATCH] net/net: Add ReadState for reuse codes

2016-05-11 Thread Jason Wang
On 2016年05月06日 18:56, Zhang Chen wrote: Signed-off-by: Zhang Chen Signed-off-by: Li Zhijian Signed-off-by: Wen Congyang Looks good, just few nits. It's better to have a commit log. --- include/net/net.h | 8 ++ net/filter-mirror.c | 60 -

Re: [Qemu-devel] [PATCH] net/net: Add ReadState for reuse codes

2016-05-11 Thread Zhang Chen
On 05/11/2016 05:01 PM, Jason Wang wrote: On 2016年05月06日 18:56, Zhang Chen wrote: Signed-off-by: Zhang Chen Signed-off-by: Li Zhijian Signed-off-by: Wen Congyang Looks good, just few nits. It's better to have a commit log. OK, I will add this log: This function is from net/socket.c,

Re: [Qemu-devel] [PATCH] net/net: Add ReadState for reuse codes

2016-05-11 Thread Jason Wang
On 2016年05月11日 19:20, Zhang Chen wrote: On 05/11/2016 05:01 PM, Jason Wang wrote: On 2016年05月06日 18:56, Zhang Chen wrote: Signed-off-by: Zhang Chen Signed-off-by: Li Zhijian Signed-off-by: Wen Congyang Looks good, just few nits. It's better to have a commit log. OK, I will add thi

Re: [Qemu-devel] [PATCH] net/net: Add ReadState for reuse codes

2016-05-11 Thread Zhang Chen
On 05/12/2016 09:11 AM, Jason Wang wrote: On 2016年05月11日 19:20, Zhang Chen wrote: On 05/11/2016 05:01 PM, Jason Wang wrote: On 2016年05月06日 18:56, Zhang Chen wrote: Signed-off-by: Zhang Chen Signed-off-by: Li Zhijian Signed-off-by: Wen Congyang Looks good, just few nits. It's bett

Re: [Qemu-devel] [PATCH] net/net: Add ReadState for reuse codes

2016-05-12 Thread Jason Wang
On 2016年05月12日 14:33, Zhang Chen wrote: +ret = net_fill_rstate(&s->rs, buf, size); + +if (ret == -1) { +goto eoc; +} else if (ret == 1) { +if (qemu_send_packet_async(&s->nc, s->rs.buf, + s->rs.packet_len, + net_socket_send_completed)

Re: [Qemu-devel] [PATCH] net/net: Add ReadState for reuse codes

2016-05-12 Thread Zhang Chen
On 05/12/2016 04:07 PM, Jason Wang wrote: On 2016年05月12日 14:33, Zhang Chen wrote: +ret = net_fill_rstate(&s->rs, buf, size); + +if (ret == -1) { +goto eoc; +} else if (ret == 1) { +if (qemu_send_packet_async(&s->nc, s->rs.buf, + s