[Qemu-devel] [PATCH] net: Allow hubports to connect to other netdevs

2018-01-10 Thread Thomas Huth
QEMU can emulate hubs to connect NICs and netdevs. This is currently primarily used for the mis-named 'vlan' feature of the networking subsystem. Now the 'vlan' feature has been marked as deprecated, since its name is rather confusing and the users often rather mis-configure their network when tryi

Re: [Qemu-devel] [PATCH] net: Allow hubports to connect to other netdevs

2018-01-10 Thread Paolo Bonzini
On 10/01/2018 15:32, Thomas Huth wrote: > QEMU can emulate hubs to connect NICs and netdevs. This is currently > primarily used for the mis-named 'vlan' feature of the networking > subsystem. Now the 'vlan' feature has been marked as deprecated, since > its name is rather confusing and the users of

Re: [Qemu-devel] [PATCH] net: Allow hubports to connect to other netdevs

2018-01-10 Thread Thomas Huth
On 10.01.2018 15:47, Paolo Bonzini wrote: > On 10/01/2018 15:32, Thomas Huth wrote: >> QEMU can emulate hubs to connect NICs and netdevs. This is currently >> primarily used for the mis-named 'vlan' feature of the networking >> subsystem. Now the 'vlan' feature has been marked as deprecated, since

Re: [Qemu-devel] [PATCH] net: Allow hubports to connect to other netdevs

2018-01-14 Thread Jason Wang
On 2018年01月10日 22:32, Thomas Huth wrote: QEMU can emulate hubs to connect NICs and netdevs. This is currently primarily used for the mis-named 'vlan' feature of the networking subsystem. Now the 'vlan' feature has been marked as deprecated, since its name is rather confusing and the users often

Re: [Qemu-devel] [PATCH] net: Allow hubports to connect to other netdevs

2018-01-15 Thread Thomas Huth
On 15.01.2018 08:40, Jason Wang wrote: > > On 2018年01月10日 22:32, Thomas Huth wrote: >> QEMU can emulate hubs to connect NICs and netdevs. This is currently >> primarily used for the mis-named 'vlan' feature of the networking >> subsystem. Now the 'vlan' feature has been marked as deprecated, since

Re: [Qemu-devel] [PATCH] net: Allow hubports to connect to other netdevs

2018-01-15 Thread Thomas Huth
On 15.01.2018 18:36, Thomas Huth wrote: > On 15.01.2018 08:40, Jason Wang wrote: [...] >> And since it was a hub, do we need to send to its netdev too inside >> net_hub_receive()? > > I currently don't think so, but I'll check again... OK, I now think we're definitely fine here. The check is real

Re: [Qemu-devel] [PATCH] net: Allow hubports to connect to other netdevs

2018-01-15 Thread Jason Wang
On 2018年01月16日 02:06, Thomas Huth wrote: On 15.01.2018 18:36, Thomas Huth wrote: On 15.01.2018 08:40, Jason Wang wrote: [...] And since it was a hub, do we need to send to its netdev too inside net_hub_receive()? I currently don't think so, but I'll check again... OK, I now think we're def