Re: [Qemu-devel] [PATCH] net: Allow specifying ifname for qemu-bridge-helper

2012-12-03 Thread Stefan Hajnoczi
On Fri, Nov 30, 2012 at 03:35:46PM +0100, Paolo Bonzini wrote: Il 30/11/2012 08:10, Mike Lovell ha scritto: On 10/12/2012 12:49 AM, Mike Lovell wrote: This makes a few changes to allow ifname to be specified when using qemu-bridge-helper with both the bridge and tap network interfaces. It

Re: [Qemu-devel] [PATCH] net: Allow specifying ifname for qemu-bridge-helper

2012-11-30 Thread Michael Tokarev
Somehow I missed this email initially.. replying now. On 12.10.2012 22:04, Mike Lovell wrote: On 10/12/2012 02:32 AM, Michael Tokarev wrote: On 12.10.2012 10:49, Mike Lovell wrote: /* request a tap device, disable PI, and add vnet header support if - * requested and it's available.

Re: [Qemu-devel] [PATCH] net: Allow specifying ifname for qemu-bridge-helper

2012-11-30 Thread Paolo Bonzini
Il 30/11/2012 11:02, Michael Tokarev ha scritto: I do like the idea of using a common prefix for the default name of tap devices. Something like qvif%d instead of tap%d in tap initialization code. But something tells me this could break compatibility with external management software where

Re: [Qemu-devel] [PATCH] net: Allow specifying ifname for qemu-bridge-helper

2012-11-30 Thread Paolo Bonzini
Il 30/11/2012 08:10, Mike Lovell ha scritto: On 10/12/2012 12:49 AM, Mike Lovell wrote: This makes a few changes to allow ifname to be specified when using qemu-bridge-helper with both the bridge and tap network interfaces. It adds the --ifname option to qemu-bridge-helper, removes the

Re: [Qemu-devel] [PATCH] net: Allow specifying ifname for qemu-bridge-helper

2012-11-29 Thread Mike Lovell
On 10/12/2012 12:49 AM, Mike Lovell wrote: This makes a few changes to allow ifname to be specified when using qemu-bridge-helper with both the bridge and tap network interfaces. It adds the --ifname option to qemu-bridge-helper, removes the restriction that ifname cannot be specified with

Re: [Qemu-devel] [PATCH] net: Allow specifying ifname for qemu-bridge-helper

2012-10-12 Thread Mike Lovell
On 10/12/2012 12:49 AM, Mike Lovell wrote: This makes a few changes to allow ifname to be specified when using qemu-bridge-helper with both the bridge and tap network interfaces. It adds the --ifname option to qemu-bridge-helper, removes the restriction that ifname cannot be specified with

[Qemu-devel] [PATCH] net: Allow specifying ifname for qemu-bridge-helper

2012-10-12 Thread Mike Lovell
This makes a few changes to allow ifname to be specified when using qemu-bridge-helper with both the bridge and tap network interfaces. It adds the --ifname option to qemu-bridge-helper, removes the restriction that ifname cannot be specified with helper for the tap interface, and adds logic to

Re: [Qemu-devel] [PATCH] net: Allow specifying ifname for qemu-bridge-helper

2012-10-12 Thread Michael Tokarev
On 12.10.2012 10:49, Mike Lovell wrote: /* request a tap device, disable PI, and add vnet header support if - * requested and it's available. */ -prep_ifreq(ifr, tap%d); + * requested and it's available. use ifname if provided for tap name. */ +prep_ifreq(ifr, ifname !=

Re: [Qemu-devel] [PATCH] net: Allow specifying ifname for qemu-bridge-helper

2012-10-12 Thread Mike Lovell
On 10/12/2012 02:32 AM, Michael Tokarev wrote: On 12.10.2012 10:49, Mike Lovell wrote: /* request a tap device, disable PI, and add vnet header support if - * requested and it's available. */ -prep_ifreq(ifr, tap%d); + * requested and it's available. use ifname if provided for