Re: [Qemu-devel] [PATCH] net: QEMU_NET_PACKET_FLAG_MORE introduced

2013-12-10 Thread Stefan Hajnoczi
On Mon, Dec 09, 2013 at 03:55:00PM +0200, Michael S. Tsirkin wrote: > On Mon, Dec 09, 2013 at 01:42:30PM +0100, Stefan Hajnoczi wrote: > > So the effect of batching should be relatively small on latency. In > > fact, it's almost like sendmmsg(2)/recvmmsg(2) but using a > > one-packet-at-a-time int

Re: [Qemu-devel] [PATCH] net: QEMU_NET_PACKET_FLAG_MORE introduced

2013-12-10 Thread Stefan Hajnoczi
On Mon, Dec 09, 2013 at 04:02:09PM +0200, Michael S. Tsirkin wrote: > On Mon, Dec 09, 2013 at 01:36:54PM +0100, Stefan Hajnoczi wrote: > > On Fri, Dec 06, 2013 at 03:44:33PM +0100, Vincenzo Maffione wrote: > > > - This patch is against the net-next tree > > > (https://github.com/stefanha/qemu.

Re: [Qemu-devel] [PATCH] net: QEMU_NET_PACKET_FLAG_MORE introduced

2013-12-09 Thread Vincenzo Maffione
Ok, We will prepare the support for the vnet-header and offloadings. However, this requires some API extensions because AFAIK only the TAP backend currently supports TSO/UFO/CSUM, and consequently virtio-net code directly calls TAP-specific functions like tap_set_offload(), tap_using_vnet_hdr()

Re: [Qemu-devel] [PATCH] net: QEMU_NET_PACKET_FLAG_MORE introduced

2013-12-09 Thread Luigi Rizzo
On Mon, Dec 9, 2013 at 3:02 PM, Michael S. Tsirkin wrote: > On Mon, Dec 09, 2013 at 01:36:54PM +0100, Stefan Hajnoczi wrote: > > On Fri, Dec 06, 2013 at 03:44:33PM +0100, Vincenzo Maffione wrote: > > > - This patch is against the net-next tree ( > https://github.com/stefanha/qemu.git) > > >

Re: [Qemu-devel] [PATCH] net: QEMU_NET_PACKET_FLAG_MORE introduced

2013-12-09 Thread Michael S. Tsirkin
On Mon, Dec 09, 2013 at 01:36:54PM +0100, Stefan Hajnoczi wrote: > On Fri, Dec 06, 2013 at 03:44:33PM +0100, Vincenzo Maffione wrote: > > - This patch is against the net-next tree > > (https://github.com/stefanha/qemu.git) > > because the first netmap patch is not in the qemu master (AFA

Re: [Qemu-devel] [PATCH] net: QEMU_NET_PACKET_FLAG_MORE introduced

2013-12-09 Thread Michael S. Tsirkin
On Mon, Dec 09, 2013 at 02:25:46PM +0100, Vincenzo Maffione wrote: > > > > 2013/12/9 Stefan Hajnoczi > > On Mon, Dec 09, 2013 at 01:14:31PM +0200, Michael S. Tsirkin wrote: > > On Mon, Dec 09, 2013 at 11:55:57AM +0100, Vincenzo Maffione wrote: > > > If you don't think adding the ne

Re: [Qemu-devel] [PATCH] net: QEMU_NET_PACKET_FLAG_MORE introduced

2013-12-09 Thread Michael S. Tsirkin
On Mon, Dec 09, 2013 at 01:42:30PM +0100, Stefan Hajnoczi wrote: > On Mon, Dec 09, 2013 at 01:14:31PM +0200, Michael S. Tsirkin wrote: > > On Mon, Dec 09, 2013 at 11:55:57AM +0100, Vincenzo Maffione wrote: > > > If you don't think adding the new flag support for virtio-net is a good > > > idea > >

Re: [Qemu-devel] [PATCH] net: QEMU_NET_PACKET_FLAG_MORE introduced

2013-12-09 Thread Vincenzo Maffione
2013/12/9 Stefan Hajnoczi > On Mon, Dec 09, 2013 at 01:14:31PM +0200, Michael S. Tsirkin wrote: > > On Mon, Dec 09, 2013 at 11:55:57AM +0100, Vincenzo Maffione wrote: > > > If you don't think adding the new flag support for virtio-net is a > good idea > > > (though TAP performance is not affected

Re: [Qemu-devel] [PATCH] net: QEMU_NET_PACKET_FLAG_MORE introduced

2013-12-09 Thread Stefan Hajnoczi
On Mon, Dec 09, 2013 at 01:14:31PM +0200, Michael S. Tsirkin wrote: > On Mon, Dec 09, 2013 at 11:55:57AM +0100, Vincenzo Maffione wrote: > > If you don't think adding the new flag support for virtio-net is a good idea > > (though TAP performance is not affected in every case) we could also make it

Re: [Qemu-devel] [PATCH] net: QEMU_NET_PACKET_FLAG_MORE introduced

2013-12-09 Thread Stefan Hajnoczi
On Fri, Dec 06, 2013 at 03:44:33PM +0100, Vincenzo Maffione wrote: > - This patch is against the net-next tree > (https://github.com/stefanha/qemu.git) > because the first netmap patch is not in the qemu master (AFAIK). You are right. I am sending a pull request now to get those patche

Re: [Qemu-devel] [PATCH] net: QEMU_NET_PACKET_FLAG_MORE introduced

2013-12-09 Thread Michael S. Tsirkin
On Mon, Dec 09, 2013 at 11:55:57AM +0100, Vincenzo Maffione wrote: > I totally agree with you, and we will propose a patch to make this possible. > > However, none of the offloadings you mentioned helps with packet rate > throughput (checksum offload doesn't really help with short packets), which

Re: [Qemu-devel] [PATCH] net: QEMU_NET_PACKET_FLAG_MORE introduced

2013-12-09 Thread Vincenzo Maffione
I totally agree with you, and we will propose a patch to make this possible. However, none of the offloadings you mentioned helps with packet rate throughput (checksum offload doesn't really help with short packets), which is the main purpose of this patch. High packet rates (say 1-5 Mpps) are int

Re: [Qemu-devel] [PATCH] net: QEMU_NET_PACKET_FLAG_MORE introduced

2013-12-09 Thread Michael S. Tsirkin
On Mon, Dec 09, 2013 at 11:20:29AM +0100, Vincenzo Maffione wrote: > Hello, >    I've done some netperf TCP_STREAM and TCP_RR virtio-net tests, using the > same configuration. > Here are the results > > ## netperf TCP_STREAM ### >     NO BATCHING BATCHING > 1  5

Re: [Qemu-devel] [PATCH] net: QEMU_NET_PACKET_FLAG_MORE introduced

2013-12-08 Thread Michael S. Tsirkin
On Fri, Dec 06, 2013 at 03:44:33PM +0100, Vincenzo Maffione wrote: > This patch extends the frontend-backend interface so that it is possible > to pass a new flag (QEMU_NET_PACKET_FLAG_MORE) when sending a packet to the > other peer. The new flag acts as a hint for the receiving peer, which can > a

Re: [Qemu-devel] [PATCH] net: QEMU_NET_PACKET_FLAG_MORE introduced

2013-12-06 Thread Stefan Weil
Am 06.12.2013 15:44, schrieb Vincenzo Maffione: > This patch extends the frontend-backend interface so that it is possible > to pass a new flag (QEMU_NET_PACKET_FLAG_MORE) when sending a packet to the > other peer. The new flag acts as a hint for the receiving peer, which can > accumulate a batch o

[Qemu-devel] [PATCH] net: QEMU_NET_PACKET_FLAG_MORE introduced

2013-12-06 Thread Vincenzo Maffione
This patch extends the frontend-backend interface so that it is possible to pass a new flag (QEMU_NET_PACKET_FLAG_MORE) when sending a packet to the other peer. The new flag acts as a hint for the receiving peer, which can accumulate a batch of packets before forwarding those packets (to the host i