[Qemu-devel] [PATCH] net: delay peer host device delete

2010-09-20 Thread Michael S. Tsirkin
With -netdev, virtio devices present offload features to guest, depending on the backend used. Thus, removing host ntedev peer while guest is active leads to guest-visible inconsistency and/or crashes. See e.g. https://bugzilla.redhat.com/show_bug.cgi?id=623735 As a solution, while guest (NIC)

Re: [Qemu-devel] [PATCH] net: delay peer host device delete

2010-09-20 Thread Anthony Liguori
On 09/20/2010 11:30 AM, Michael S. Tsirkin wrote: With -netdev, virtio devices present offload features to guest, depending on the backend used. Thus, removing host ntedev peer while guest is active leads to guest-visible inconsistency and/or crashes. See e.g.

Re: [Qemu-devel] [PATCH] net: delay peer host device delete

2010-09-20 Thread Michael S. Tsirkin
On Mon, Sep 20, 2010 at 11:41:45AM -0500, Anthony Liguori wrote: On 09/20/2010 11:30 AM, Michael S. Tsirkin wrote: With -netdev, virtio devices present offload features to guest, depending on the backend used. Thus, removing host ntedev peer while guest is active leads to guest-visible

Re: [Qemu-devel] [PATCH] net: delay peer host device delete

2010-09-20 Thread Anthony Liguori
On 09/20/2010 11:47 AM, Michael S. Tsirkin wrote: On Mon, Sep 20, 2010 at 11:41:45AM -0500, Anthony Liguori wrote: On 09/20/2010 11:30 AM, Michael S. Tsirkin wrote: With -netdev, virtio devices present offload features to guest, depending on the backend used. Thus, removing host

Re: [Qemu-devel] [PATCH] net: delay peer host device delete

2010-09-20 Thread Michael S. Tsirkin
On Mon, Sep 20, 2010 at 11:56:56AM -0500, Anthony Liguori wrote: On 09/20/2010 11:47 AM, Michael S. Tsirkin wrote: On Mon, Sep 20, 2010 at 11:41:45AM -0500, Anthony Liguori wrote: On 09/20/2010 11:30 AM, Michael S. Tsirkin wrote: With -netdev, virtio devices present offload features to guest,

Re: [Qemu-devel] [PATCH] net: delay peer host device delete

2010-09-20 Thread Anthony Liguori
On 09/20/2010 12:14 PM, Michael S. Tsirkin wrote: On Mon, Sep 20, 2010 at 11:56:56AM -0500, Anthony Liguori wrote: On 09/20/2010 11:47 AM, Michael S. Tsirkin wrote: On Mon, Sep 20, 2010 at 11:41:45AM -0500, Anthony Liguori wrote: On 09/20/2010 11:30 AM, Michael S. Tsirkin

Re: [Qemu-devel] [PATCH] net: delay peer host device delete

2010-09-20 Thread Anthony Liguori
On 09/20/2010 01:14 PM, Anthony Liguori wrote: Here's what makes sense to me: 1) async device remove + poll device status/removal notification + remove backend The management tool needs to determine when the device is gone and remove the backend. 2) sync device remove + remove backend