Re: [Qemu-devel] [PATCH] net: don't set native endianness

2015-10-14 Thread Greg Kurz
On Wed, 14 Oct 2015 17:02:28 +0300 "Michael S. Tsirkin" wrote: > On Wed, Oct 14, 2015 at 03:54:32PM +0200, Greg Kurz wrote: > > On Wed, 14 Oct 2015 12:26:58 +0300 > > "Michael S. Tsirkin" wrote: > > > > > commit 5be7d9f1b1452613b95c6ba70b8d7ad3d0797991 > > >

Re: [Qemu-devel] [PATCH] net: don't set native endianness

2015-10-14 Thread Marcel Apfelbaum
On 10/14/2015 12:26 PM, Michael S. Tsirkin wrote: commit 5be7d9f1b1452613b95c6ba70b8d7ad3d0797991 vhost-net: tell tap backend about the vnet endianness makes vhost net always try to set LE - even if that matches the native endian-ness. This makes it fail on older kernels on x86 without

[Qemu-devel] [PATCH] net: don't set native endianness

2015-10-14 Thread Michael S. Tsirkin
commit 5be7d9f1b1452613b95c6ba70b8d7ad3d0797991 vhost-net: tell tap backend about the vnet endianness makes vhost net always try to set LE - even if that matches the native endian-ness. This makes it fail on older kernels on x86 without TUNSETVNETLE support. To fix, make

Re: [Qemu-devel] [PATCH] net: don't set native endianness

2015-10-14 Thread Jason Wang
On 10/14/2015 05:26 PM, Michael S. Tsirkin wrote: > commit 5be7d9f1b1452613b95c6ba70b8d7ad3d0797991 > vhost-net: tell tap backend about the vnet endianness > makes vhost net always try to set LE - even if that matches the > native endian-ness. > > This makes it fail on older kernels on x86

Re: [Qemu-devel] [PATCH] net: don't set native endianness

2015-10-14 Thread Greg Kurz
On Wed, 14 Oct 2015 12:26:58 +0300 "Michael S. Tsirkin" wrote: > commit 5be7d9f1b1452613b95c6ba70b8d7ad3d0797991 > vhost-net: tell tap backend about the vnet endianness > makes vhost net always try to set LE - even if that matches the > native endian-ness. > > This makes it

Re: [Qemu-devel] [PATCH] net: don't set native endianness

2015-10-14 Thread Michael S. Tsirkin
On Wed, Oct 14, 2015 at 03:54:32PM +0200, Greg Kurz wrote: > On Wed, 14 Oct 2015 12:26:58 +0300 > "Michael S. Tsirkin" wrote: > > > commit 5be7d9f1b1452613b95c6ba70b8d7ad3d0797991 > > vhost-net: tell tap backend about the vnet endianness > > makes vhost net always try to set