Re: [Qemu-devel] [PATCH] net: move rxfilter_notify() to net.c

2013-11-18 Thread Amos Kong
On Fri, Nov 15, 2013 at 11:49:27AM -0500, Vlad Yasevich wrote: > On 11/15/2013 10:27 AM, Stefan Hajnoczi wrote: > >On Tue, Nov 05, 2013 at 07:00:48PM +0800, Amos Kong wrote: > >>@@ -545,7 +523,7 @@ static int virtio_net_handle_rx_mode(VirtIONet *n, > >>uint8_t cmd, > >> return VIRTIO_NET_

Re: [Qemu-devel] [PATCH] net: move rxfilter_notify() to net.c

2013-11-15 Thread Vlad Yasevich
On 11/15/2013 10:27 AM, Stefan Hajnoczi wrote: On Tue, Nov 05, 2013 at 07:00:48PM +0800, Amos Kong wrote: @@ -545,7 +523,7 @@ static int virtio_net_handle_rx_mode(VirtIONet *n, uint8_t cmd, return VIRTIO_NET_ERR; } -rxfilter_notify(nc); +rxfilter_notify(nc, object_get_c

Re: [Qemu-devel] [PATCH] net: move rxfilter_notify() to net.c

2013-11-15 Thread Stefan Hajnoczi
On Tue, Nov 05, 2013 at 07:00:48PM +0800, Amos Kong wrote: > @@ -545,7 +523,7 @@ static int virtio_net_handle_rx_mode(VirtIONet *n, > uint8_t cmd, > return VIRTIO_NET_ERR; > } > > -rxfilter_notify(nc); > +rxfilter_notify(nc, object_get_canonical_path(OBJECT(n->qdev))); >

[Qemu-devel] [PATCH] net: move rxfilter_notify() to net.c

2013-11-05 Thread Amos Kong
rxfilter_notify() is a generic function for all nics, not only for virtio_net, so move it to net.c Signed-off-by: Amos Kong --- hw/net/virtio-net.c | 32 +--- include/net/net.h | 1 + net/net.c | 20 3 files changed, 26 insertions(+),