Re: [Qemu-devel] [PATCH] net: netmap: probe netmap interface for virtio-net header

2016-02-22 Thread Jason Wang
On 02/18/2016 09:34 PM, Vincenzo Maffione wrote: >>> static void netmap_set_offload(NetClientState *nc, int csum, int tso4, int >>> tso6, >>> >> @@ -376,7 +394,7 @@ static void netmap_set_offload(NetClientState *nc, >>> >> int csum, int tso4, int tso6, >>> >> * enables the offloadings. >

Re: [Qemu-devel] [PATCH] net: netmap: probe netmap interface for virtio-net header

2016-02-18 Thread Vincenzo Maffione
2016-02-18 3:52 GMT+01:00 Jason Wang : > > > On 02/05/2016 06:30 PM, Vincenzo Maffione wrote: >> Previous implementation of has_ufo, has_vnet_hdr, has_vnet_hdr_len, etc. >> did not really probe for virtio-net header support for the netmap >> interface attached to the backend. These callbacks were c

Re: [Qemu-devel] [PATCH] net: netmap: probe netmap interface for virtio-net header

2016-02-17 Thread Jason Wang
On 02/05/2016 06:30 PM, Vincenzo Maffione wrote: > Previous implementation of has_ufo, has_vnet_hdr, has_vnet_hdr_len, etc. > did not really probe for virtio-net header support for the netmap > interface attached to the backend. These callbacks were correct for > VALE ports, but incorrect for har

[Qemu-devel] [PATCH] net: netmap: probe netmap interface for virtio-net header

2016-02-05 Thread Vincenzo Maffione
Previous implementation of has_ufo, has_vnet_hdr, has_vnet_hdr_len, etc. did not really probe for virtio-net header support for the netmap interface attached to the backend. These callbacks were correct for VALE ports, but incorrect for hardware NICs, pipes, monitors, etc. This patch fixes the imp