Re: [Qemu-devel] [PATCH] network: Added option to disable NIC option roms

2012-02-15 Thread Gerhard Wiesinger
On Mon, 13 Feb 2012, Gerhard Wiesinger wrote: On Fri, 27 Jan 2012, Gerhard Wiesinger wrote: On Thu, 26 Jan 2012, Markus Armbruster wrote: Gerd Hoffmann writes: On 01/26/12 08:45, Markus Armbruster wrote: Gerhard Wiesinger writes: Option ROM for network interface cards (NICs) can now ex

Re: [Qemu-devel] [PATCH] network: Added option to disable NIC option roms

2012-02-12 Thread Gerhard Wiesinger
On Fri, 27 Jan 2012, Gerhard Wiesinger wrote: On Thu, 26 Jan 2012, Markus Armbruster wrote: Gerd Hoffmann writes: On 01/26/12 08:45, Markus Armbruster wrote: Gerhard Wiesinger writes: Option ROM for network interface cards (NICs) can now explicitly disabled with romfile=disabled (or ro

Re: [Qemu-devel] [PATCH] network: Added option to disable NIC option roms

2012-02-01 Thread Anthony Liguori
On 01/26/2012 04:45 AM, Gerd Hoffmann wrote: On 01/26/12 08:45, Markus Armbruster wrote: Gerhard Wiesinger writes: Option ROM for network interface cards (NICs) can now explicitly disabled with romfile=disabled (or romfile=no or romfile=none) parameter. With hotplugable NICs (currently NE2000

Re: [Qemu-devel] [PATCH] network: Added option to disable NIC option roms

2012-01-27 Thread Gerhard Wiesinger
On Thu, 26 Jan 2012, Markus Armbruster wrote: Gerd Hoffmann writes: On 01/26/12 08:45, Markus Armbruster wrote: Gerhard Wiesinger writes: Option ROM for network interface cards (NICs) can now explicitly disabled with romfile=disabled (or romfile=no or romfile=none) parameter. With hotplug

Re: [Qemu-devel] [PATCH] network: Added option to disable NIC option roms

2012-01-26 Thread Gerhard Wiesinger
On Thu, 26 Jan 2012, Markus Armbruster wrote: Gerd Hoffmann writes: On 01/26/12 08:45, Markus Armbruster wrote: Gerhard Wiesinger writes: Option ROM for network interface cards (NICs) can now explicitly disabled with romfile=disabled (or romfile=no or romfile=none) parameter. With hotplug

Re: [Qemu-devel] [PATCH] network: Added option to disable NIC option roms

2012-01-26 Thread Markus Armbruster
Gerd Hoffmann writes: > On 01/26/12 08:45, Markus Armbruster wrote: >> Gerhard Wiesinger writes: >> >>> Option ROM for network interface cards (NICs) can now explicitly disabled >>> with romfile=disabled (or romfile=no or romfile=none) parameter. >>> With hotplugable NICs (currently NE2000, PCN

Re: [Qemu-devel] [PATCH] network: Added option to disable NIC option roms

2012-01-26 Thread Gerd Hoffmann
On 01/26/12 08:45, Markus Armbruster wrote: > Gerhard Wiesinger writes: > >> Option ROM for network interface cards (NICs) can now explicitly disabled >> with romfile=disabled (or romfile=no or romfile=none) parameter. >> With hotplugable NICs (currently NE2000, PCNET) romfile=(empty) didn't work

Re: [Qemu-devel] [PATCH] network: Added option to disable NIC option roms

2012-01-26 Thread Markus Armbruster
Gerhard Wiesinger writes: > Option ROM for network interface cards (NICs) can now explicitly disabled > with romfile=disabled (or romfile=no or romfile=none) parameter. > With hotplugable NICs (currently NE2000, PCNET) romfile=(empty) didn't work. > This patch disables Option ROMs for iPXE for al

Re: [Qemu-devel] [PATCH] network: Added option to disable NIC option roms

2012-01-25 Thread Gerhard Wiesinger
On Thu, 12 Jan 2012, Gerd Hoffmann wrote: Hi, I'm not sure about the consequences (hotplugging feature, etc.) when changing it to romfile as in other PCI devices. There should be no noticable difference. I don't know the consequences there so I think it is better to let that code and jus

[Qemu-devel] [PATCH] network: Added option to disable NIC option roms

2012-01-25 Thread Gerhard Wiesinger
Option ROM for network interface cards (NICs) can now explicitly disabled with romfile=disabled (or romfile=no or romfile=none) parameter. With hotplugable NICs (currently NE2000, PCNET) romfile=(empty) didn't work. This patch disables Option ROMs for iPXE for alls supported NICs (hotplugable and

Re: [Qemu-devel] [PATCH] network: Added option to disable NIC option roms

2012-01-12 Thread Gerhard Wiesinger
On Mon, 9 Jan 2012, Gerd Hoffmann wrote: Hi, if (!pci_dev->qdev.hotplugged) { static int loaded = 0; -if (!loaded) { +if (!loaded && pci_has_not_explicitly_disabled_option_romfile(pci_dev)) { rom_add_option("pxe-ne2k_pci.rom", -1); loade

Re: [Qemu-devel] [PATCH] network: Added option to disable NIC option roms

2012-01-11 Thread Gerd Hoffmann
Hi, > I'm not sure about the consequences (hotplugging feature, etc.) when > changing it to romfile as in other PCI devices. There should be no noticable difference. > Also the patch is more > generic and supports static and dynamic devices (hotplugable and > possible future devices). Hotplug

Re: [Qemu-devel] [PATCH] network: Added option to disable NIC option roms

2012-01-09 Thread Stefan Hajnoczi
On Sun, Jan 08, 2012 at 09:56:20PM +0100, Gerhard Wiesinger wrote: > On Sun, 8 Jan 2012, Stefan Hajnoczi wrote: > > >On Sun, Jan 8, 2012 at 11:55 AM, Gerhard Wiesinger > >wrote: > >>Option ROM for network interface cards (NICs) can now explicitly disabled > >>with romfile=disabled parameter. Wit

Re: [Qemu-devel] [PATCH] network: Added option to disable NIC option roms

2012-01-09 Thread Gerd Hoffmann
Hi, > if (!pci_dev->qdev.hotplugged) { > static int loaded = 0; > -if (!loaded) { > +if (!loaded && > pci_has_not_explicitly_disabled_option_romfile(pci_dev)) { > rom_add_option("pxe-ne2k_pci.rom", -1); > loaded = 1; > } I think y

Re: [Qemu-devel] [PATCH] network: Added option to disable NIC option roms

2012-01-08 Thread Gerhard Wiesinger
On Sun, 8 Jan 2012, Stefan Hajnoczi wrote: On Sun, Jan 8, 2012 at 11:55 AM, Gerhard Wiesinger wrote: Option ROM for network interface cards (NICs) can now explicitly disabled with romfile=disabled parameter. With hotplugable NICs (currently NE2000, PCNET) romfile=(empty) didn't work. This patc

Re: [Qemu-devel] [PATCH] network: Added option to disable NIC option roms

2012-01-08 Thread Stefan Hajnoczi
On Sun, Jan 8, 2012 at 11:55 AM, Gerhard Wiesinger wrote: > Option ROM for network interface cards (NICs) can now explicitly disabled > with romfile=disabled parameter. With hotplugable NICs (currently NE2000, > PCNET) > romfile=(empty) didn't work. This patch disables Option ROMs for iPXE for > a

[Qemu-devel] [PATCH] network: Added option to disable NIC option roms

2012-01-08 Thread Gerhard Wiesinger
Option ROM for network interface cards (NICs) can now explicitly disabled with romfile=disabled parameter. With hotplugable NICs (currently NE2000, PCNET) romfile=(empty) didn't work. This patch disables Option ROMs for iPXE for alls supported NICs (hotplugable and non hotplugable). Examples with