Re: [Qemu-devel] [PATCH] nseries: Don't use qemu_hw_version()

On 12 November 2015 at 15:04, Eduardo Habkost wrote: > On Thu, Nov 12, 2015 at 01:39:24PM +0200, Michael S. Tsirkin wrote: >> On Wed, Nov 11, 2015 at 07:42:47PM -0200, Eduardo Habkost wrote: >> > nseries doesn't use qemu_set_hw_version() and doesn't need the >> > compatibility magic of qemu_hw_ver

Re: [Qemu-devel] [PATCH] nseries: Don't use qemu_hw_version()

On Thu, Nov 12, 2015 at 01:39:24PM +0200, Michael S. Tsirkin wrote: > On Wed, Nov 11, 2015 at 07:42:47PM -0200, Eduardo Habkost wrote: > > nseries doesn't use qemu_set_hw_version() and doesn't need the > > compatibility magic of qemu_hw_version(). Use QEMU_VERSION > > directly. > > > > Signed-off-

Re: [Qemu-devel] [PATCH] nseries: Don't use qemu_hw_version()

On Wed, Nov 11, 2015 at 07:42:47PM -0200, Eduardo Habkost wrote: > nseries doesn't use qemu_set_hw_version() and doesn't need the > compatibility magic of qemu_hw_version(). Use QEMU_VERSION > directly. > > Signed-off-by: Eduardo Habkost This looks very wrong. We should be reducing the users of

[Qemu-devel] [PATCH] nseries: Don't use qemu_hw_version()

nseries doesn't use qemu_set_hw_version() and doesn't need the compatibility magic of qemu_hw_version(). Use QEMU_VERSION directly. Signed-off-by: Eduardo Habkost --- hw/arm/nseries.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/arm/nseries.c b/hw/arm/nseries.c index 2a