Re: [Qemu-devel] [PATCH] numa: clarify error message when node index is out of range in -numa dist, ...

2018-05-15 Thread Igor Mammedov
On Tue, 15 May 2018 16:24:50 +0200 Andrew Jones wrote: > Pretty long patch summary line. Do we not try to limit that? > > On Tue, May 15, 2018 at 12:40:58PM +0200, Igor Mammedov wrote: > > When using following CLI: > > -numa dist,src=128,dst=1,val=20 > > user getsi a

Re: [Qemu-devel] [PATCH] numa: clarify error message when node index is out of range in -numa dist, ...

2018-05-15 Thread Andrew Jones
Pretty long patch summary line. Do we not try to limit that? On Tue, May 15, 2018 at 12:40:58PM +0200, Igor Mammedov wrote: > When using following CLI: > -numa dist,src=128,dst=1,val=20 > user getsi a rather confusing error message: gets >"Invalid node 128, max possible could be 128" >

[Qemu-devel] [PATCH] numa: clarify error message when node index is out of range in -numa dist, ...

2018-05-15 Thread Igor Mammedov
When using following CLI: -numa dist,src=128,dst=1,val=20 user getsi a rather confusing error message: "Invalid node 128, max possible could be 128" Where 128 is number of nodes that QEMU supports (MAX_NODES), while src/dst is an index up to that limit, so it should be MAX_NODES - 1 in error