Re: [Qemu-devel] [PATCH] nvme: fix CMB endianness confusion

2018-11-22 Thread Kevin Wolf
Am 22.11.2018 um 19:23 hat Paolo Bonzini geschrieben: > The CMB is marked as DEVICE_LITTLE_ENDIAN, so the data must be > read/written as if it was little-endian output (in the case of > big endian, we get two swaps, one in the memory core and one > in nvme.c). > > Signed-off-by: Paolo Bonzini Th

Re: [Qemu-devel] [PATCH] nvme: fix CMB endianness confusion

2018-11-22 Thread Peter Maydell
On 22 November 2018 at 18:23, Paolo Bonzini wrote: > The CMB is marked as DEVICE_LITTLE_ENDIAN, so the data must be > read/written as if it was little-endian output (in the case of > big endian, we get two swaps, one in the memory core and one > in nvme.c). > > Signed-off-by: Paolo Bonzini > ---

[Qemu-devel] [PATCH] nvme: fix CMB endianness confusion

2018-11-22 Thread Paolo Bonzini
The CMB is marked as DEVICE_LITTLE_ENDIAN, so the data must be read/written as if it was little-endian output (in the case of big endian, we get two swaps, one in the memory core and one in nvme.c). Signed-off-by: Paolo Bonzini --- hw/block/nvme.c | 7 ++- 1 file changed, 2 insertions(+), 5