Re: [Qemu-devel] [PATCH] nvme: fix identify to be NVMe 1.1 compliant

2015-11-17 Thread Christoph Hellwig
On Tue, Nov 17, 2015 at 05:41:04PM +, Keith Busch wrote: > On Tue, Nov 17, 2015 at 09:33:11AM -0800, Busch, Keith wrote: > > I accidently deleted my comment. Here's what it said: > > > > +list = g_malloc(data_len); > > +for (i = 0; i < n->num_namespaces; i++) { > > +if (i <= mi

Re: [Qemu-devel] [PATCH] nvme: fix identify to be NVMe 1.1 compliant

2015-11-17 Thread Keith Busch
On Tue, Nov 17, 2015 at 09:33:11AM -0800, Busch, Keith wrote: > I accidently deleted my comment. Here's what it said: > > +list = g_malloc(data_len); > +for (i = 0; i < n->num_namespaces; i++) { > +if (i <= min_nsid) { > +continue; > +} > +list[i] = i; >

Re: [Qemu-devel] [PATCH] nvme: fix identify to be NVMe 1.1 compliant

2015-11-17 Thread Busch, Keith
> Thanks for the fix! Minor comment below, no need to fix. > > Acked-by: Keith Busch I accidently deleted my comment. Here's what it said: +list = g_malloc(data_len); +for (i = 0; i < n->num_namespaces; i++) { +if (i <= min_nsid) { +continue; +} +list

Re: [Qemu-devel] [PATCH] nvme: fix identify to be NVMe 1.1 compliant

2015-11-17 Thread Keith Busch
On Tue, Nov 17, 2015 at 02:08:09PM +0100, Christoph Hellwig wrote: > NVMe 1.1 requires devices to implement a Namespace List subcommand of > the identify command. Qemu not only not implements this features, but > also misinterprets it as an Identify Controller request. Due to this > any OS trying

[Qemu-devel] [PATCH] nvme: fix identify to be NVMe 1.1 compliant

2015-11-17 Thread Christoph Hellwig
NVMe 1.1 requires devices to implement a Namespace List subcommand of the identify command. Qemu not only not implements this features, but also misinterprets it as an Identify Controller request. Due to this any OS trying to use the Namespace List will fail the probe. Signed-off-by: Christoph H