Re: [Qemu-devel] [PATCH] opts: fix NULL pointer derefernce in get_opt_value

2018-07-17 Thread Paolo Bonzini
On 16/07/2018 20:47, Daniel P. Berrange wrote: > On Mon, Jul 16, 2018 at 06:41:46PM +0100, Mike Krinkin wrote: >> The value argument can be NULL, for example, in hw/i386/multiboot.c >> in the load_multiboot function get_opt_value is explicitly called >> with NULL as the second argument. >> >> The

Re: [Qemu-devel] [PATCH] opts: fix NULL pointer derefernce in get_opt_value

2018-07-16 Thread Mike Krinkin
On Mon, Jul 16, 2018 at 7:47 PM Daniel P. Berrange wrote: > On Mon, Jul 16, 2018 at 06:41:46PM +0100, Mike Krinkin wrote: > > The value argument can be NULL, for example, in hw/i386/multiboot.c > > in the load_multiboot function get_opt_value is explicitly called > > with NULL as the second

Re: [Qemu-devel] [PATCH] opts: fix NULL pointer derefernce in get_opt_value

2018-07-16 Thread Daniel P. Berrange
On Mon, Jul 16, 2018 at 06:41:46PM +0100, Mike Krinkin wrote: > The value argument can be NULL, for example, in hw/i386/multiboot.c > in the load_multiboot function get_opt_value is explicitly called > with NULL as the second argument. > > The problem was introduced in commit 950c4e6c94b1 ("opts:

[Qemu-devel] [PATCH] opts: fix NULL pointer derefernce in get_opt_value

2018-07-16 Thread Mike Krinkin
The value argument can be NULL, for example, in hw/i386/multiboot.c in the load_multiboot function get_opt_value is explicitly called with NULL as the second argument. The problem was introduced in commit 950c4e6c94b1 ("opts: don't silently truncate long option values"). This change fixes the