On Mon, Oct 16, 2017 at 10:29:12PM +0200, Stefan Weil wrote:
> gcc warning:
>
> /qemu/util/oslib-posix.c:304:11: error:
> variable ‘addr’ might be clobbered by ‘longjmp’ or ‘vfork’
> [-Werror=clobbered]
>
> Fix also some related data types:
>
> numpages, hpagesize are used as pointer offset.
>
Sorry, Philippe, I did not notice that "git send-email"
did not add you to the addressee list.
And I forgot to add "v3" to the subject line.
I should not send e-mails late in the night ...
Stefan
Am 16.10.2017 um 22:29 schrieb Stefan Weil:
> gcc warning:
>
> /qemu/util/oslib-posix.c:304:11:
gcc warning:
/qemu/util/oslib-posix.c:304:11: error:
variable ‘addr’ might be clobbered by ‘longjmp’ or ‘vfork’
[-Werror=clobbered]
Fix also some related data types:
numpages, hpagesize are used as pointer offset.
Always use size_t for them and also for the derived
numpages_per_thread and size
Am 10.10.2017 um 16:43 schrieb Richard Henderson:
> On 10/09/2017 10:39 PM, Stefan Weil wrote:
>> Am 09.10.2017 um 23:58 schrieb Richard Henderson:
>>> On 10/07/2017 08:55 AM, Stefan Weil wrote:
+char *addr = memset_args->addr;
+uint64_t numpages = memset_args->numpages;
>
On 10/10/2017 09:48 AM, Stefan Weil wrote:
> If we really expect more than 2^32 pages, touching all those pages
> will need a significant time even on fast machines.
Sure. But surely taking a long time is better than silently ignoring high-bits
of a quantity.
> What about using size_t instead of
On 10/09/2017 10:39 PM, Stefan Weil wrote:
> Am 09.10.2017 um 23:58 schrieb Richard Henderson:
>> On 10/07/2017 08:55 AM, Stefan Weil wrote:
>>> +char *addr = memset_args->addr;
>>> +uint64_t numpages = memset_args->numpages;
>>> +uint64_t hpagesize = memset_args->hpagesize;
Am 09.10.2017 um 23:58 schrieb Richard Henderson:
> On 10/07/2017 08:55 AM, Stefan Weil wrote:
>> +char *addr = memset_args->addr;
>> +uint64_t numpages = memset_args->numpages;
>> +uint64_t hpagesize = memset_args->hpagesize;
>> +unsigned i;
>
> Match numpages prop
On 10/07/2017 08:55 AM, Stefan Weil wrote:
> +char *addr = memset_args->addr;
> +uint64_t numpages = memset_args->numpages;
> +uint64_t hpagesize = memset_args->hpagesize;
> +unsigned i;
Match numpages properly while you're at it?
r~
gcc warning:
/qemu/util/oslib-posix.c:304:11: error:
variable ‘addr’ might be clobbered by ‘longjmp’ or ‘vfork’
[-Werror=clobbered]
Use also an unsigned loop variable which better matches numpages.
Signed-off-by: Stefan Weil
---
Please cc qemu-trivial if you think this is trivial enough.
Th
Applied to trivial, thank you!
/mjt
gcc reports this warning with -Wclobbered:
util/oslib-posix.c: In function ‘os_mem_prealloc’:
util/oslib-posix.c:374:49: error: argument ‘memory’ might be clobbered by
‘longjmp’ or ‘vfork’ [-Werror=clobbered]
Fix this and simplify the code by using an existing macro.
Signed-off-by: Stefan Weil
11 matches
Mail list logo
