Re: [Qemu-devel] [PATCH] pc: fix possible NULL pointer dereference in pc_machine_get_device_memory_region_size()

2019-06-24 Thread Igor Mammedov
On Thu, 20 Jun 2019 22:46:15 -0300 Eduardo Habkost wrote: > On Fri, Jun 21, 2019 at 02:29:29AM +0200, Paolo Bonzini wrote: > > On 10/06/19 15:50, Igor Mammedov wrote: > > > QEMU will crash when device-memory-region-size property is read if > > > ms->device_memory > > > wasn't initialized yet.

Re: [Qemu-devel] [PATCH] pc: fix possible NULL pointer dereference in pc_machine_get_device_memory_region_size()

2019-06-20 Thread Eduardo Habkost
On Fri, Jun 21, 2019 at 02:29:29AM +0200, Paolo Bonzini wrote: > On 10/06/19 15:50, Igor Mammedov wrote: > > QEMU will crash when device-memory-region-size property is read if > > ms->device_memory > > wasn't initialized yet. > > > > Crash can be reproduced with: > > $QEMU -preconfig -qmp

Re: [Qemu-devel] [PATCH] pc: fix possible NULL pointer dereference in pc_machine_get_device_memory_region_size()

2019-06-20 Thread Paolo Bonzini
On 10/06/19 15:50, Igor Mammedov wrote: > QEMU will crash when device-memory-region-size property is read if > ms->device_memory > wasn't initialized yet. > > Crash can be reproduced with: > $QEMU -preconfig -qmp unix:qmp_socket,server,nowait & > ./scripts/qmp/qom-get -s qmp_socket

Re: [Qemu-devel] [PATCH] pc: fix possible NULL pointer dereference in pc_machine_get_device_memory_region_size()

2019-06-10 Thread Paolo Bonzini
On 10/06/19 15:50, Igor Mammedov wrote: > QEMU will crash when device-memory-region-size property is read if > ms->device_memory > wasn't initialized yet. > > Crash can be reproduced with: > $QEMU -preconfig -qmp unix:qmp_socket,server,nowait & > ./scripts/qmp/qom-get -s qmp_socket

[Qemu-devel] [PATCH] pc: fix possible NULL pointer dereference in pc_machine_get_device_memory_region_size()

2019-06-10 Thread Igor Mammedov
QEMU will crash when device-memory-region-size property is read if ms->device_memory wasn't initialized yet. Crash can be reproduced with: $QEMU -preconfig -qmp unix:qmp_socket,server,nowait & ./scripts/qmp/qom-get -s qmp_socket /machine.device-memory-region-size Instead of crashing return 0