Re: [Qemu-devel] [PATCH] pc_piix: enable legacy hotplug for Xen

2014-02-05 Thread Stefano Stabellini
On Wed, 5 Feb 2014, Paolo Bonzini wrote: > Il 05/02/2014 17:54, Stefano Stabellini ha scritto: > > > > I'm not sure how this is related to fw_cfg? fw_cfg is just a simple > > > key-value > > > > store. If hvmloader doesn't use it, it should be a burden. > > I was referring to the fact that QEMU m

Re: [Qemu-devel] [PATCH] pc_piix: enable legacy hotplug for Xen

2014-02-05 Thread Paolo Bonzini
Il 05/02/2014 17:54, Stefano Stabellini ha scritto: > I'm not sure how this is related to fw_cfg? fw_cfg is just a simple key-value > store. If hvmloader doesn't use it, it should be a burden. I was referring to the fact that QEMU might not have all the info that need to be written to fw_cfg w

Re: [Qemu-devel] [PATCH] pc_piix: enable legacy hotplug for Xen

2014-02-05 Thread Sander Eikelenboom
Wednesday, February 5, 2014, 5:35:32 PM, you wrote: > On Tue, 4 Feb 2014, Sander Eikelenboom wrote: >> Tuesday, February 4, 2014, 10:55:18 PM, you wrote: >> >> > Il 04/02/2014 22:32, Michael S. Tsirkin ha scritto: >> >> xenfv has no fwcfg and so does not load acpi from QEMU. >> >> as such new ac

Re: [Qemu-devel] [PATCH] pc_piix: enable legacy hotplug for Xen

2014-02-05 Thread Stefano Stabellini
On Wed, 5 Feb 2014, Paolo Bonzini wrote: > Il 05/02/2014 17:41, Stefano Stabellini ha scritto: > > > Yeah, especially because nowadays "-M pc" works with Xen. It would be > > nice if > > > fw_cfg could be enabled even for Xen on all machines except the legacy "-M > > > xenfv". > > > > > > Stefano,

Re: [Qemu-devel] [PATCH] pc_piix: enable legacy hotplug for Xen

2014-02-05 Thread Stefano Stabellini
On Wed, 5 Feb 2014, Sander Eikelenboom wrote: > > On Tue, 4 Feb 2014, Sander Eikelenboom wrote: > >> Tuesday, February 4, 2014, 10:55:18 PM, you wrote: > >> > >> > Il 04/02/2014 22:32, Michael S. Tsirkin ha scritto: > >> >> xenfv has no fwcfg and so does not load acpi from QEMU. > >> >> as such ne

Re: [Qemu-devel] [PATCH] pc_piix: enable legacy hotplug for Xen

2014-02-05 Thread Paolo Bonzini
Il 05/02/2014 17:41, Stefano Stabellini ha scritto: > Yeah, especially because nowadays "-M pc" works with Xen. It would be nice if > fw_cfg could be enabled even for Xen on all machines except the legacy "-M > xenfv". > > Stefano, could you give it a shot now that you'll be soon done with 4.4?

Re: [Qemu-devel] [PATCH] pc_piix: enable legacy hotplug for Xen

2014-02-05 Thread Stefano Stabellini
On Tue, 4 Feb 2014, Paolo Bonzini wrote: > Il 04/02/2014 22:32, Michael S. Tsirkin ha scritto: > > xenfv has no fwcfg and so does not load acpi from QEMU. > > as such new acpi features don't work. > > > > Reported-by: Sander Eikelenboom > > Signed-off-by: Michael S. Tsirkin > > --- > > > > Sand

Re: [Qemu-devel] [PATCH] pc_piix: enable legacy hotplug for Xen

2014-02-05 Thread Stefano Stabellini
On Tue, 4 Feb 2014, Sander Eikelenboom wrote: > Tuesday, February 4, 2014, 10:55:18 PM, you wrote: > > > Il 04/02/2014 22:32, Michael S. Tsirkin ha scritto: > >> xenfv has no fwcfg and so does not load acpi from QEMU. > >> as such new acpi features don't work. > >> > >> Reported-by: Sander Eikelen

Re: [Qemu-devel] [PATCH] pc_piix: enable legacy hotplug for Xen

2014-02-04 Thread Sander Eikelenboom
Tuesday, February 4, 2014, 10:55:18 PM, you wrote: > Il 04/02/2014 22:32, Michael S. Tsirkin ha scritto: >> xenfv has no fwcfg and so does not load acpi from QEMU. >> as such new acpi features don't work. >> >> Reported-by: Sander Eikelenboom >> Signed-off-by: Michael S. Tsirkin >> --- >> >> Sa

Re: [Qemu-devel] [PATCH] pc_piix: enable legacy hotplug for Xen

2014-02-04 Thread Paolo Bonzini
Il 04/02/2014 22:32, Michael S. Tsirkin ha scritto: xenfv has no fwcfg and so does not load acpi from QEMU. as such new acpi features don't work. Reported-by: Sander Eikelenboom Signed-off-by: Michael S. Tsirkin --- Sander, could you pleas econfirm this works for you? Also, Xen really should

[Qemu-devel] [PATCH] pc_piix: enable legacy hotplug for Xen

2014-02-04 Thread Michael S. Tsirkin
xenfv has no fwcfg and so does not load acpi from QEMU. as such new acpi features don't work. Reported-by: Sander Eikelenboom Signed-off-by: Michael S. Tsirkin --- Sander, could you pleas econfirm this works for you? Also, Xen really should switch to fw cfg some day ... hw/i386/pc_piix.c | 11